fix(typescript-estree, eslint-plugin): stop adding ParenthesizedExpressions to node maps #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uniqueiniquity
requested review from
JamesHenry and
armano2
and removed request for
JamesHenry
uniqueiniquity
changed the title
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 96.78% 96.79% +<.01%
==========================================
Files 56 56
Lines 2522 2524 +2
Branches 372 373 +1
==========================================
+ Hits 2441 2443 +2
Misses 42 42
Partials 39 39
|
armano2
reviewed
Feb 7, 2019
armano2
previously approved these changes
Feb 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 96.78% 96.79% +<.01%
==========================================
Files 56 56
Lines 2522 2525 +3
Branches 372 374 +2
==========================================
+ Hits 2441 2444 +3
Misses 42 42
Partials 39 39
|
|
Failing from line ending issues in the fixture |
armano2
previously approved these changes
Feb 8, 2019
bradzacher
reviewed
Feb 8, 2019
packages/eslint-plugin/lib/rules/no-unnecessary-type-assertion.js
Outdated
Show resolved
Hide resolved
armano2
approved these changes
Feb 8, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
…int#226) ### Disallow `/// <reference path="" />` comments but it's triggered on: - `/// <reference types="foo" />` - `/// <reference lib="es2017.string" />` - `/// <reference no-default-lib="true"/>` types/lib/no-default-lib can't be replaced by es6 imports
Luckeu
pushed a commit
to Luckeu/typescript-eslint
that referenced
this pull request
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #212
The core issue for the crashes is that the TS AST has individual nodes for parenthesized expressions, but the ESTree AST does not.
Assuming a tree of the form
(E), whereEis some expression, we would map the TS version ofEto the ESTree version ofE, but the ESTree version ofEwould map to the TS version of(E), thereby causing the missingtypeproperty in the repro.This PR makes it so we don't add TS nodes of type
ParenthesizedExpressionto the ES->TS map.I also moved some things around in the particular rule you were investigating; in particular, there's no good reason for us to use the TS node to get the text to check against the provided options, so I switched it to using the ESTree node.
fixes: #187