-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(typescript-estree): mention file specifics in project service allowDefaultProject error #11635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript-estree): mention file specifics in project service allowDefaultProject error #11635
Conversation
…lowDefaultProject error
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
View your CI Pipeline Execution ↗ for commit 46020d0
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11635 +/- ##
==========================================
+ Coverage 90.93% 90.96% +0.03%
==========================================
Files 506 506
Lines 51370 51446 +76
Branches 8476 8494 +18
==========================================
+ Hits 46711 46796 +85
+ Misses 4646 4637 -9
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR Checklist
Overview
If
parseSettings.projectService.allowDefaultProject
is defined, thenopenClientFileFromProjectService
can know to throw a more informative error message about the file path not being matched.💖