Skip to content

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

If parseSettings.projectService.allowDefaultProject is defined, then openClientFileFromProjectService can know to throw a more informative error message about the file path not being matched.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 46020d0
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68de8aae1dd5f00008247181
😎 Deploy Preview https://deploy-preview-11635--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🟢 up 16 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Sep 26, 2025

View your CI Pipeline Execution ↗ for commit 46020d0

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 9s View ↗
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 57s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-10-02 14:35:39 UTC

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.96%. Comparing base (9fd1cc6) to head (46020d0).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11635      +/-   ##
==========================================
+ Coverage   90.93%   90.96%   +0.03%     
==========================================
  Files         506      506              
  Lines       51370    51446      +76     
  Branches     8476     8494      +18     
==========================================
+ Hits        46711    46796      +85     
+ Misses       4646     4637       -9     
  Partials       13       13              
Flag Coverage Δ
unittest 90.96% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...escript-estree/src/useProgramFromProjectService.ts 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 26, 2025 14:01
bradzacher
bradzacher previously approved these changes Sep 30, 2025
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 2, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5c50292 into typescript-eslint:main Oct 3, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Explicitly mention allowDefaultProject not matching a file

2 participants