Skip to content

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 29, 2025

PR Checklist

Overview

Adds a special-case exemption for an intersection of a literal and an object, as suggested in #1790 (comment).

I think Codecov is wrong to complain. The new functions are hit. We're just not merging coverage reports.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 29, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bea544c
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68e3b29c28623e0008ccc702
😎 Deploy Preview https://deploy-preview-11660--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Sep 29, 2025

View your CI Pipeline Execution ↗ for commit bea544c

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 5s View ↗
nx run-many -t lint ✅ Succeeded 3m 20s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 3s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 5s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-10-06 12:27:49 UTC

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 9.52381% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.67%. Comparing base (7f5fed7) to head (bea544c).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/type-utils/src/isTypeBrandedLiteralLike.ts 7.31% 38 Missing ⚠️

❌ Your patch status has failed because the patch coverage (9.52%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11660      +/-   ##
==========================================
- Coverage   90.74%   90.67%   -0.07%     
==========================================
  Files         516      517       +1     
  Lines       51987    52028      +41     
  Branches     8588     8588              
==========================================
+ Hits        47174    47177       +3     
- Misses       4799     4837      +38     
  Partials       14       14              
Flag Coverage Δ
unittest 90.67% <9.52%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin/src/rules/prefer-readonly-parameter-types.ts 100.00% <100.00%> (ø)
...ackages/type-utils/src/isTypeBrandedLiteralLike.ts 7.31% <7.31%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 29, 2025 12:12
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a few questions/nits from me 🚀🚀🚀

@ronami ronami added the awaiting response Issues waiting for a reply from the OP or another party label Sep 29, 2025
@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 30, 2025
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀 Looking good!

I added a couple of comments, mostly around a case I missed on the last review (my apologies).

@ronami ronami added the awaiting response Issues waiting for a reply from the OP or another party label Oct 4, 2025
@JoshuaKGoldberg JoshuaKGoldberg requested a review from ronami October 6, 2025 12:50
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 6, 2025
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 6, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit a974191 into typescript-eslint:main Oct 6, 2025
67 of 68 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the prefer-readonly-parameter-types-tagged-primitive branch October 6, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prefer-readonly-parameter-types] false positive with tagged primitive type
2 participants