-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [prefer-readonly-parameter-types] ignore tagged primitives #11660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [prefer-readonly-parameter-types] ignore tagged primitives #11660
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
View your CI Pipeline Execution ↗ for commit bea544c
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (9.52%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11660 +/- ##
==========================================
- Coverage 90.74% 90.67% -0.07%
==========================================
Files 516 517 +1
Lines 51987 52028 +41
Branches 8588 8588
==========================================
+ Hits 47174 47177 +3
- Misses 4799 4837 +38
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just a few questions/nits from me 🚀🚀🚀
packages/eslint-plugin/src/rules/prefer-readonly-parameter-types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀 Looking good!
I added a couple of comments, mostly around a case I missed on the last review (my apologies).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
a974191
into
typescript-eslint:main
PR Checklist
Overview
Adds a special-case exemption for an intersection of a literal and an object, as suggested in #1790 (comment).
I think Codecov is wrong to complain. The new functions are hit. We're just not merging coverage reports.
💖