Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): skip seenTypes for unions in isTypeReadonly #4043


Copy link

PR Checklist


If a type within a union type was already added to seenTypes, we don't need to recurse into it.

Copy link

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 24, 2021 20:28
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #4043 (4693b87) into master (f418f48) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4043   +/-   ##
  Coverage   93.33%   93.33%           
  Files         152      152           
  Lines        8014     8014           
  Branches     2568     2569    +1     
  Hits         7480     7480           
  Misses        180      180           
  Partials      354      354           
Flag Coverage Δ
unittest 93.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/util/isTypeReadonly.ts 94.36% <100.00%> (ø)

@bradzacher bradzacher added the bug Something isn't working label Oct 25, 2021
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[prefer-readonly-parameter-types] Maximum call stack size exceeded
2 participants