Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scope-manager): ignore ECMA version #5889


Copy link

Removes part of the public API for the parser and scope-manager.

PR Checklist


Per the issue, ignores ecmaVersion in the options, and assumes it's always ESNext.

Copy link

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

nx-cloud bot commented Oct 26, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 04e8bed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher linked an issue Oct 26, 2022 that may be closed by this pull request
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #5889 (04e8bed) into v6 (c4e0d86) will increase coverage by 0.02%.
The diff coverage is 88.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #5889      +/-   ##
+ Coverage   91.33%   91.35%   +0.02%     
  Files         361      364       +3     
  Lines       12044    12185     +141     
  Branches     3506     3546      +40     
+ Hits        11000    11132     +132     
- Misses        748      752       +4     
- Partials      296      301       +5     
Flag Coverage Δ
unittest 91.35% <88.35%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/ScopeManager.ts 77.21% <0.00%> (-2.54%) ⬇️
packages/scope-manager/src/analyze.ts 57.89% <0.00%> (-7.49%) ⬇️
...ript-estree/src/create-program/createSourceFile.ts 87.50% <0.00%> (ø)
...t-estree/src/create-program/useProvidedPrograms.ts 84.84% <50.00%> (ø)
...-estree/src/create-program/createDefaultProgram.ts 78.26% <71.42%> (+0.98%) ⬆️
...ges/typescript-estree/src/create-program/shared.ts 83.33% <75.00%> (ø) 78.06% <78.57%> (ø)
...-estree/src/create-program/createProjectProgram.ts 93.47% <81.81%> (ø)
...escript-estree/src/parseSettings/inferSingleRun.ts 90.90% <90.90%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 93.33% <93.33%> (ø)
... and 8 more

@JoshuaKGoldberg JoshuaKGoldberg merged commit c446386 into typescript-eslint:v6 Oct 26, 2022
72 of 74 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the scope-manager-ignore-ecma-version branch October 26, 2022 03:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

[scope-manager] should ignore parserOptions.ecmaVersion
3 participants