-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [restrict-plus-operands] check += #892
feat(eslint-plugin): [restrict-plus-operands] check += #892
Conversation
Thanks for the PR, @a-tarasyuk! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint |
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
==========================================
+ Coverage 94.23% 94.25% +0.02%
==========================================
Files 126 126
Lines 5377 5379 +2
Branches 1510 1511 +1
==========================================
+ Hits 5067 5070 +3
Misses 177 177
+ Partials 133 132 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this
Hmm - I hate doing this, but technically this is a breaking feature change, could you please add an option for this check, that is off by default? We can switch it to be on by default with the next major. |
6f3ded5
to
c6bd2ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
Fixes #878