class property type: first commit #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigsong
commented
Sep 6, 2020
| @@ -291,7 +291,7 @@ class Square { | |||
| } | |||
| ``` | |||
|
|
|||
| In cases where not all paths of a constructor assign to an instance member, the property is considered to potentially be `undefined`. | |||
| 생성자의 모든 경로가 인스턴스 멤버에 할당한 것이 아닐 경우, 프로퍼티는 잠재적으로 `undefined`가 됩니다. | |||
There was a problem hiding this comment.
이 부분을 어떻게 번역해야 할지 모르겠습니다 😅
|
|
||
| ```ts | ||
| class Square { | ||
| // definite assignment assertion | ||
| // 확정적 할당 단언 |
There was a problem hiding this comment.
guyeol
reviewed
Sep 7, 2020
| @@ -272,14 +272,14 @@ In fact, TypeScript's editor support will try to display them as overloads when | |||
|
|
|||
| To learn more, check out [the pull request](https://github.com/microsoft/TypeScript/pull/38234) for labeled tuple elements. | |||
|
|
|||
| ## Class Property Inference from Constructors | |||
| ## 생성자로부터 클래스 프로퍼티 타입 추론하기 | |||
There was a problem hiding this comment.
Suggested change
| ## 생성자로부터 클래스 프로퍼티 타입 추론하기 | |
| ## 생성자로부터 클래스 프로퍼티 타입 추론하기 (Class Property Inference from Constructors) |
bumkeyy
reviewed
Sep 7, 2020
| // v | ||
| sideLength!: number; | ||
| // ^^^^^^^^ | ||
| // type annotation | ||
| // 타입 선언 |
There was a problem hiding this comment.
Suggested change
| // 타입 선언 | |
| // 타입 표기 |
번역 용어 참고
bumkeyy
reviewed
Sep 7, 2020
|
|
||
| <!--prettier-ignore --> | ||
| ```ts | ||
| class Square { | ||
| // Previously both of these were any | ||
| // 이전에 이 둘은 any였습니다. |
There was a problem hiding this comment.
Suggested change
| // 이전에 이 둘은 any였습니다. | |
| // 이전에 any로 추론했습니다. |
zigsong
force-pushed
the
issue171-class-property
branch
from
e2d2b61 to
fd76587
Compare
guyeol
approved these changes
Sep 9, 2020
dvlprsh
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR전에 아래의 사항들을 확인하셨나요? 확인하셨다면, 체크해주세요!
PR에 대한 간단한 내용 설명을 부탁드립니다!
일부 용어는 https://meetup.toast.com/posts/247 이곳에서 가져다 사용했고,
아직도 이해가 잘 안 되는 부분이 있어서 코멘트 남깁니다!