Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package.json: Add repository url field #1511

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Update package.json: Add repository url field #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@
"keywords": [],
"author": "typicode <typicode@gmail.com>",
"license": "SEE LICENSE IN ./LICENSE",
"repository": {
"type": "git",
"url": "git+https://github.com/typicode/json-server.git"
},
Copy link
Contributor Author

@glensc glensc Jan 31, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh. fcking code style again.

i made edit from web, copied from husky package.json and fixed path.

i guess here can be no git hooks to prevent it, it should be formatted on CI pipeline and aborted if mismatch.

you didn't not notice this yourself when looking diffs in github files view?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing it on my phone on the GitHub app lol and I still don't see the issue. It's not published so it's fine. Thanks for the heads up.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, the tabs I guess?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes tabs.

image

Copy link
Owner

@typicode typicode Jan 31, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think any command that updates package.json like npm version npm install should fix it (which happen fairly often with v1 work). You can make a PR or leave it as it is, as you prefer :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you to finish it :)

however,
I just randomly read husky install code. and you may not like what it does. the way I read it out is if it finds single tab in the file it will format whole file with tabs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE:

but, the code is buggy as well, so it doesn't work?

"devDependencies": {
"@sindresorhus/tsconfig": "^5.0.0",
"@tailwindcss/typography": "^0.5.10",
Expand Down