-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iconic-salmon-fa:1.0.0 #575
Conversation
Is there a process defined on how to remove or deprecate the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two import statements that should be changed, but other than that it looks good. Thanks!
@@ -0,0 +1,104 @@ | |||
#import "../iconic-salmon-fa.typ": * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import should use the package specification:
#import "../iconic-salmon-fa.typ": * | |
#import "@preview/iconic-salmon-fa:1.0.0": * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any hard requirement for this? I see that several other packages also reference the local version (which btw is the only way to access a new version to generate a new PDF file before publishing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not a hard requirement. It is just better because then people can copy/paste your example and start from here. It also makes it easier to tell which version of the package is used if the file is given out-of-context.
I agree that this is however not ideal to generate PDF files. The best solution as far as I know is to generate them with the relative import, and then update it to use the package import before submitting here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I have included the instructions in the README.md
😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll merge it as is then.
@@ -0,0 +1,4 @@ | |||
// #import "@preview/iconic-salmon-fa:1.0.0": github-info, gitlab-info | |||
#import "../iconic-salmon-fa.typ": github-info, gitlab-info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
#import "../iconic-salmon-fa.typ": github-info, gitlab-info | |
#import "@preview/iconic-salmon-fa:1.0.0": github-info, gitlab-info |
What you could do is to publish a new minor version of |
92aab43
to
d06d87c
Compare
I am submitting
Description: This is the renamed version of the
socialhub-fa
(#218) package with the new name introduced in #536. It also fixes a small inconsistency in the generated example PDF (different icon for GitLab due to initially wrong build environment).I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE