Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to add the
SOAPAction
header (required by spec!) to HTTP requests by setting it on the soap message instance, this change allows to specify the value for this header to be passed when calling arinse.client.SoapClient
instance as an optional second param (defaults to empty string), which is then passed torinse.message.SoapMessage.request
, where it is passed, together with the headers set on theSoapMessage
instance, torequests.Request
.So instead of:
you can now write:
I also fixed a superfluous comma in the
request.Request
instantiation call.IMHO, you should also be able to specify the URL on a per-request basis, but that would be another PR.