pkg/strace/epsocket: fix handling of IP4/IP6 #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.85% // Head: 74.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2614 +/- ##
==========================================
+ Coverage 74.85% 74.95% +0.09%
==========================================
Files 409 409
Lines 41384 41385 +1
==========================================
+ Hits 30979 31020 +41
+ Misses 10405 10365 -40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I am not sure why the original code does this but it returns a binary string in FullAddress:Addr. Change the code so that Addr is net.IP().String(). Add tests. Fixes:u-root#2609 Signed-off-by: Ronald G. Minnich <rminnich@google.com>
Signed-off-by: Ronald G. Minnich <rminnich@google.com>
Signed-off-by: Ronald G. Minnich <rminnich@google.com>
binjip978
reviewed
Feb 11, 2023
binjip978
added
the
Awaiting author
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
rminnich
removed
the
Awaiting author
binjip978
approved these changes
Feb 12, 2023
|
Issue #2609 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why the original code does this but
it returns a binary string in FullAddress:Addr.
Change the code so that Addr is net.IP().String().
Add tests.
Fixes:#2609
Signed-off-by: Ronald G. Minnich rminnich@google.com