-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swtich singularity+conda setup to singularity setup for snakemake tasks #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to singularity in rule create_multiqc_config
…instead of run to run the job in singularity container
wilkb777
requested changes
Apr 10, 2023
wilkb777
approved these changes
Apr 18, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
This PR deals with and closes #69. It refactors snakemake pipeline to run all tasks in singularity env instead of singularity+conda setup (and singularity for few tasks). This will improve reproducibility.
What was done?
aggregate_sample_rename_configs
, which usedrun
directive, was refactored to useshell
directive, asrun
directive would not allow use of container and instead would be run directly by snakemake in the environment it is present in.Please fill in the checklist below and comment as needed.
configs/multiqc_config_template.jinja2
and scriptsrc/quac_watch/create_mutliqc_configs.py
as necessary? Not modified.Changelog.md
file with change logs in recommended format?Anything else reviewer should know?
No.