Fixed AIP api collections with nil descriptions #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwillia
requested review from
ConnorSheremeta,
jefferya and
lagoan
as code owners
lagoan
reviewed
Apr 20, 2023
pgwillia
commented
Apr 20, 2023
Comment on lines
16
to
32
| statements = [] | ||
| statements << RDF::Statement(subject: self_subject, predicate: RDF.type, object: RDF::Vocab::PCDM.Collection) | ||
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::PCDM.memberOf, | ||
| object: @collection.community_id) | ||
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.title, object: @collection.title) | ||
| if @collection.description.present? | ||
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.description, | ||
| object: @collection.description) | ||
| end | ||
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.accessRights, | ||
| object: @collection.visibility) | ||
| statements << RDF::Statement(subject: self_subject, predicate: TERMS[:ual].restricted_collection, | ||
| object: @collection.restricted) | ||
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.created, | ||
| object: @collection.created_at) | ||
| statements << RDF::Statement(subject: self_subject, predicate: TERMS[:ual].record_created_in_jupiter, | ||
| object: @collection.record_created_at) |
There was a problem hiding this comment.
Suggested change
| statements = [] | |
| statements << RDF::Statement(subject: self_subject, predicate: RDF.type, object: RDF::Vocab::PCDM.Collection) | |
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::PCDM.memberOf, | |
| object: @collection.community_id) | |
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.title, object: @collection.title) | |
| if @collection.description.present? | |
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.description, | |
| object: @collection.description) | |
| end | |
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.accessRights, | |
| object: @collection.visibility) | |
| statements << RDF::Statement(subject: self_subject, predicate: TERMS[:ual].restricted_collection, | |
| object: @collection.restricted) | |
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.created, | |
| object: @collection.created_at) | |
| statements << RDF::Statement(subject: self_subject, predicate: TERMS[:ual].record_created_in_jupiter, | |
| object: @collection.record_created_at) | |
| statements = [ | |
| RDF::Statement(subject: self_subject, predicate: RDF.type, object: RDF::Vocab::PCDM.Collection), | |
| RDF::Statement(subject: self_subject, predicate: RDF::Vocab::PCDM.memberOf, object: @collection.community_id), | |
| RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.title, object: @collection.title), | |
| RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.description, object: @collection.description), | |
| RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.accessRights, object: @collection.visibility), | |
| RDF::Statement(subject: self_subject, predicate: TERMS[:ual].restricted_collection, | |
| object: @collection.restricted), | |
| RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.created, object: @collection.created_at), | |
| RDF::Statement(subject: self_subject, predicate: TERMS[:ual].record_created_in_jupiter, | |
| object: @collection.record_created_at) | |
| ] | |
| if @collection.description.present? | |
| statements << RDF::Statement(subject: self_subject, predicate: RDF::Vocab::DC.description, | |
| object: @collection.description) | |
| end |
This could work.
pgwillia
force-pushed
the
3117_aip_api_nil_description
branch
from
7766274
to
e4a68a4
Compare
After running the rake task to enqueue all the collections and communities we received many errors like: `ArgumentError: Statement #<RDF::Statement:0x9808(<http://era.ualberta.localhost/aip/v1/collections/a93cbb63-4bb2-4deb-a952-c96c4c851c8c> <http://purl.org/dc/terms/description> nil .)> is incomplete` 274 of our collections have no description. If there is no description than we can leave out the statement about description. I checked for which attributes are required, and `description` is the only one here that might be nil https://github.com/ualbertalib/jupiter/blob/18351c928226b3d6883b1d78da24a820374b73d1/db/schema.rb#L91-L107
…rendered by the AIP api. In terms of the markdown, what we really want here is the content as opposed to the display per se. That said, if there is a link to something external it would be ideal to be able to keep the url even if it doesn't display as a hyperlink.
pgwillia
force-pushed
the
3117_aip_api_nil_description
branch
from
e4a68a4
to
ee949ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After running the rake task to enqueue all the collections and communities we received many errors like:
ArgumentError: Statement #<RDF::Statement:0x9808(<http://era.ualberta.localhost/aip/v1/collections/a93cbb63-4bb2-4deb-a952-c96c4c851c8c> <http://purl.org/dc/terms/description> nil .)> is incomplete274 of our collections have no description.
Related to #3117
What's New
If there is no description than we can leave out the statement about description.
Also added a test that demonstrates that markdown will not be stripped or rendered by the AIP api.