-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch ingest task #3143
Open
piyapongch
wants to merge
40
commits into
main
Choose a base branch
from
batch_ingest_task
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Batch ingest task #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a4cccc1.
- Add backtrace error message and ingest_errors.csv
…e to error and success message
piyapongch
requested review from
ConnorSheremeta,
jefferya,
lagoan and
pgwillia
as code owners
June 8, 2023 17:58
@piyapongch There are some unresolved merge conflicts which I believe is causing CI to fail |
Generated by 🚫 Danger |
Just a heads up @piyapongch that there still appears to be two rubocop offences along with danger complaining about a missing change log entry. I’ve posted the rubocop offences below from CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Please describe any relevant motivation and context for these changes.
Related to # (issue)
What's New
Please summarize what's new or changed in this PR.
Remember to request a reviewer when you submit!