Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch ingest task #3143

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Batch ingest task #3143

wants to merge 40 commits into from

Conversation

piyapongch
Copy link
Member

Context

Please describe any relevant motivation and context for these changes.

Related to # (issue)

What's New

Please summarize what's new or changed in this PR.

Remember to request a reviewer when you submit!

This reverts commit a4cccc1.
- Add backtrace error message and ingest_errors.csv
@ConnorSheremeta
Copy link
Contributor

@piyapongch There are some unresolved merge conflicts which I believe is causing CI to fail

@github-actions
Copy link

1 Error
🚫 Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.
1 Warning
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by 🚫 Danger

@ConnorSheremeta
Copy link
Contributor

Just a heads up @piyapongch that there still appears to be two rubocop offences along with danger complaining about a missing change log entry. I’ve posted the rubocop offences below from CI:

Offenses:

lib/tasks/batch_ingest.rake:99:17: C: [Correctable] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. ([https://rubystyle.guide#no-double-indent](https://rubystyle.guide/#no-double-indent))
                ENV['HOSTNAME'].split('.')[0]), item.title]
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/tasks/batch_ingest.rake:381:9: C: [Correctable] Layout/IndentationConsistency: Inconsistent indentation detected. ([https://rubystyle.guide#spaces-indentation](https://rubystyle.guide/#spaces-indentation), https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions)
        (thesis_data[:visibility_after_embargo])
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

335 files inspected, 2 offenses detected, 2 offenses autocorrectable
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants