Skip to content

Conversation

andrewstec
Copy link
Contributor

  • Removes deprecated Github UBC Circle Ci integration
  • Leaves Github Dev Students Circle CI integration alone, as in perfect working state and passing
  • Updates Github Students Circle CI integration, as missing PUBLICHOSTNAME update to replace localhost with cs.ubc.ca due to a change in Github integration requirements.

@andrewstec andrewstec requested a review from winstan April 23, 2020 15:20
@andrewstec
Copy link
Contributor Author

@winstan

If you can have a quick look just to familiarize yourself with these updates for future reference. This will eventually trickle down to the CPSC310 CircleCI configuration to update it.

Copy link
Member

@winstan winstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
(I recall that localhost is no longer valid.)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1419

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.404%

Totals Coverage Status
Change from base Build 1415: 0.0%
Covered Lines: 3349
Relevant Lines: 3900

💛 - Coveralls

@andrewstec andrewstec merged commit d35642e into master Apr 23, 2020
@andrewstec andrewstec deleted the patch/circle-ci-students-cs-PUBLICHOST-update branch April 27, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants