Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver file to absolute path on host #270

Merged
merged 3 commits into from
Jun 23, 2018
Merged

Deliver file to absolute path on host #270

merged 3 commits into from
Jun 23, 2018

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Jun 23, 2018

👷 Changes

Command is executed over SSH and does not interact with the containerized daemon - /app/host/ is inappropriate here

see #270 (comment) - closes #271

🔦 Testing Instructions

I just used @brian-nguyen's configuration to send Inertia's CONTRIBUTING.md over to the bumper deployment

bobbook:inertia robertlin$ inertia aws send CONTRIBUTING.md
[WARNING] Configuration version 'latest' does not match your Inertia CLI version 'test'
File CONTRIBUTING.md has been copied to $HOME/inertia/project/CONTRIBUTING.md on remote aws
bobbook:inertia robertlin$ inertia aws ssh
[WARNING] Configuration version 'latest' does not match your Inertia CLI version 'test'
Last login: Sat Jun 23 08:16:08 2018 from 24.86.161.145

       __|  __|_  )
       _|  (     /   Amazon Linux AMI
      ___|\___|___|

https://aws.amazon.com/amazon-linux-ami/2017.09-release-notes/
28 package(s) needed for security, out of 37 available
Run "sudo yum update" to apply all updates.
Amazon Linux version 2018.03 is available.
[ec2-user@ip-172-31-4-61 ~]$ cd in/project
[ec2-user@ip-172-31-4-61 project]$ ls
client                  Dockerfile
CONTRIBUTING.md         Makefile
docker-compose.dev.yml  README.md
docker-compose.yml      server
[ec2-user@ip-172-31-4-61 project]$ cat CONTRIBUTING.md
# :books: Contributing

This document outlines key considerations and tips for anyone contributing to Inertia.

- [Opening an Issue](#opening-an-issue)
- [Submitting a Pull Request](#submitting-a-pull-request)
- [Development Tips](#development-tips)

------

# Opening an Issue
# ...etc etc

Command is executed over SSH and does not interact with the containerized daemon - /app/host/ is inappropriate here
@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Jun 23, 2018
@bobheadxi bobheadxi requested a review from a team June 23, 2018 08:44
@bobheadxi
Copy link
Member Author

bobheadxi commented Jun 23, 2018

Known Issues

bobbook:inertia robertlin$ inertia aws send test/README.md
[WARNING] Configuration version 'latest' does not match your Inertia CLI version 'test'
File test/README.md has been copied to $HOME/inertia/project/test/README.md on remote aws
bobbook:inertia robertlin$ inertia aws ssh
[WARNING] Configuration version 'latest' does not match your Inertia CLI version 'test'
Last login: Sat Jun 23 08:30:05 2018 from 24.86.161.145

       __|  __|_  )
       _|  (     /   Amazon Linux AMI
      ___|\___|___|

https://aws.amazon.com/amazon-linux-ami/2017.09-release-notes/
28 package(s) needed for security, out of 37 available
Run "sudo yum update" to apply all updates.
Amazon Linux version 2018.03 is available.
[ec2-user@ip-172-31-4-61 ~]$ cd inertia/project
[ec2-user@ip-172-31-4-61 project]$ ls
client                  Makefile
CONTRIBUTING.md         README.md
docker-compose.dev.yml  server
docker-compose.yml      test
Dockerfile
[ec2-user@ip-172-31-4-61 project]$ cd test
-bash: cd: test: Not a directory

no a directory??? interestingly enough, cat test reveals the README:

[ec2-user@ip-172-31-4-61 project]$ cat test
# Test

This directory contains assets and scripts used for setting up Inertia test environments.

See [CONTRIBUTING.md](https://github.com/ubclaunchpad/inertia/blob/master/CONTRIBUTING.md#testing-and-locally-deploying) for more details.

Same issue with --dest. Currently investigating, might leave for another PR

edit: see #271

@coveralls
Copy link

coveralls commented Jun 23, 2018

Pull Request Test Coverage Report for Build 890

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 46.495%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deploy.go 0 2 0.0%
client/ssh.go 0 4 0.0%
Totals Coverage Status
Change from base Build 876: 0.08%
Covered Lines: 1539
Relevant Lines: 3310

💛 - Coveralls

@bobheadxi
Copy link
Member Author

jk I fixed it!

bobbook:inertia robertlin$ inertia aws send test/README.md --dest robertsayshi6/readme.md
[WARNING] Configuration version 'latest' does not match your Inertia CLI version 'test'
File test/README.md has been copied to $HOME/inertia/project/robertsayshi6/readme.md on remote aws

then on the remote:

[ec2-user@ip-172-31-4-61 project]$ ls
client                  robertsayshi2
CONTRIBUTING.md         robertsayshi3
coverage.out            robertsayshi4
docker-compose.dev.yml  robertsayshi5
docker-compose.yml      robertsayshi.md
Dockerfile              server
Makefile                test
README.md
[ec2-user@ip-172-31-4-61 project]$ ls robertsayshi5
README.md

yiss

@bobheadxi bobheadxi merged commit 75ce408 into master Jun 23, 2018
@bobheadxi bobheadxi deleted the daemon/bugfix/send branch June 23, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: finalized needs review and final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix inertia [remote] send behaviour with custom paths
2 participants