Migrate 'cmd' to 'main', licence update #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All command-line functionality now in 'main' package * 'inertia daemon' commands are now completely disabled outside of the inertia-daemon image
bobheadxi
requested review from
rogermyang,
PiggySpeed,
chadlagore and
arjansandhu
Merged
bobheadxi
changed the title
PiggySpeed
reviewed
Feb 27, 2018
| @@ -33,7 +33,7 @@ sudo docker run -d --rm \ | |||
| -p "$PORT":8081 \ | |||
| -v /var/run/docker.sock:/var/run/docker.sock \ | |||
| -v $HOME:/app/host \ | |||
| -e DAEMON="true" \ | |||
| -e INERTIA_DAEMON='true' \ | |||
There was a problem hiding this comment.
Just an observation - it looks like use of " " and ' ' is inconsistent in our shell scripts.
There was a problem hiding this comment.
That's a good point... I'm not actually sure how interchangeable they are 🤔
Will look into it
There was a problem hiding this comment.
I think the way we have it now is fine: see this explanation for single vs double quotes in bash
Single for string literals, double for things like "$MYVAR"
There was a problem hiding this comment.
Cool, thanks for the link!
|
Thanks for the review @PiggySpeed! |
PiggySpeed
approved these changes
Feb 27, 2018
rogermyang
approved these changes
Feb 27, 2018
|
Thanks for the review @rogermyang! This one will affect your ticket (#72), remember to make sure you are up to date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s):
👷 Changes
This is largely a simple code migration. ⏫
daemonand having it conflict with the command 😢Apache 2.0licence - we are already underMIT🔦 Testing Instructions
go install inertia daemon run # should no longer work