Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user functions for dynamodb #62

Merged
merged 47 commits into from
Nov 2, 2018
Merged
Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
2602d53
db branch
joy8zhang Oct 13, 2018
3dcd204
Renames facade to better name
Oct 13, 2018
0412c01
dbfacade
joy8zhang Oct 13, 2018
e0ac8a7
db branch
joy8zhang Oct 13, 2018
f7d114f
Renames facade to better name
Oct 13, 2018
3187599
dbfacade
joy8zhang Oct 13, 2018
5263971
Finish up some DBFacade methods
Oct 14, 2018
6d19d2e
Update pipfile, finally
chuck-sys Oct 19, 2018
ba18580
pipfile change
joy8zhang Oct 20, 2018
05d82fc
fixed merge conflicts in facade and pipfile
joy8zhang Oct 20, 2018
5eb41fa
db branch
joy8zhang Oct 13, 2018
cf2b637
Renames facade to better name
Oct 13, 2018
5257610
dbfacade
joy8zhang Oct 13, 2018
48a944f
Finish up some DBFacade methods
Oct 14, 2018
0828ecc
Update pipfile, finally
chuck-sys Oct 19, 2018
a4699f5
Temporarily remove functional code in dbfacade
Oct 20, 2018
0568447
Remove testing file
Oct 20, 2018
98cc895
Create good dbfacade tests
Oct 20, 2018
a322ec4
Add init file
Oct 20, 2018
3f00b08
Remove stupid quotation marks
Oct 20, 2018
334f7b7
fixing merge conflicts fro facade (commented out ver) pipfile
joy8zhang Oct 20, 2018
c4950a5
Remove the test file that keeps coming back
Oct 20, 2018
c76ad74
Skeleton files created for dynamodb
Oct 20, 2018
229e1e1
db branch
joy8zhang Oct 13, 2018
a7df5fb
Renames facade to better name
Oct 13, 2018
d4841ce
pipfile change
joy8zhang Oct 20, 2018
95a391e
Skeleton files created for dynamodb
Oct 20, 2018
cf0a975
Add dynamodb tests
Oct 20, 2018
b3d30fe
Update travis to make tests work
Oct 20, 2018
a4be6ad
Try to fix travis again
Oct 20, 2018
acc702d
Fix tests
Oct 20, 2018
be1b662
Add AWS CLI configure script
chuck-sys Oct 25, 2018
22149c4
Add user table docs
chuck-sys Oct 25, 2018
dd7c066
Add instructions on testing database
chuck-sys Oct 25, 2018
a8a1429
Refactor user creation to separate module
chuck-sys Oct 26, 2018
ef01f31
Create mocks for facade testing
chuck-sys Oct 26, 2018
409e73c
retrive_user implemented not testsed
joy8zhang Oct 27, 2018
0c5221e
solving merge conflicts
joy8zhang Oct 27, 2018
25faa63
implemented create_tables, retrieve_user and query_user in dynamodb.py
joy8zhang Oct 27, 2018
c1091d4
fixed up codestyle
joy8zhang Oct 27, 2018
733f9f0
Make filter parameter work with more parameters
Oct 27, 2018
1239d29
Merge branch 'master' into dynamodb
Oct 27, 2018
660c393
Fix permissions conversion from string to enum
Oct 27, 2018
eb8b339
Move awscli from pip to pipenv
Oct 27, 2018
c5b3036
Merge branch 'master' into dynamodb
chuck-sys Oct 31, 2018
3db099e
Add user storage validation to ddb
chuck-sys Oct 31, 2018
9be71df
Make requested changes
chuck-sys Nov 2, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ language: python
python:
- "3.7-dev"
install:
- sudo apt-get update
- sudo apt-get install -y default-jdk
- pip install pipenv
- pipenv install --dev
- gem install mdl
before_script:
- scripts/download_dynamodb_and_run.sh
script:
- pipenv run pycodestyle .
- pipenv run pydocstyle .
Expand Down
1 change: 1 addition & 0 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ codecov = "*"
pytest-cov = "*"
pydocstyle = "*"
ipython = "*"
awscli = "*"

[requires]
python_version = "3.7"
151 changes: 108 additions & 43 deletions Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,25 @@ You can also install it as a
cd scripts/
make install
```

### Testing the Database Locally

Some tests must also be run on the DynamoDB database. We recommend that you
download it and keep it running in the background while executing tests.

```bash
wget https://s3-us-west-2.amazonaws.com/dynamodb-local/dynamodb_local_latest.tar.gz
mkdir DynamoDB
tar -xvf dynamodb_local_latest.tar.gz --directory DynamoDB

# Configure AWS
scripts/setup_localaws.sh

# Run DynamoDB through Java
cd DynamoDB/
java -Djava.library.path=./DynamoDBLocal_lib -jar DynamoDBLocal.jar -sharedDb
```

To have it executing in the background, simply add an ampersand (&) at the end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to add slightly more detail here for users that don't know much about running things in the background (i.e. what does it mean to kill a process?). That might be too complex for this though.

of the java command. Just remember to kill it after you're done.

Loading