Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Team Command #91

Merged
merged 15 commits into from
Nov 24, 2018
Merged

Update Team Command #91

merged 15 commits into from
Nov 24, 2018

Conversation

vyzw
Copy link
Contributor

@vyzw vyzw commented Nov 10, 2018

Pull Request

Description

Give a brief description of your changes:

  • Add help text to Team Command and test

Testing

If testing this change requires extra setup, please document it here:

Ticket(s)

Closes #50
Closes #51
Closes #52

(Create a copy of that line for each Github Issue affected,
and replace "Affects" with "Closes" if merging this will close the relevant ticket.)

@vyzw vyzw requested a review from a team as a code owner November 10, 2018 22:55
Copy link
Collaborator

@chuck-sys chuck-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please remove .DS_Store and .swp binary files.

command/commands/team.py Outdated Show resolved Hide resolved
tests/command/commands/team_test.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #91 into master will decrease coverage by 0.22%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage    94.5%   94.27%   -0.23%     
==========================================
  Files          21       21              
  Lines         983      996      +13     
  Branches       45       47       +2     
==========================================
+ Hits          929      939      +10     
- Misses         48       49       +1     
- Partials        6        8       +2
Impacted Files Coverage Δ
tests/command/commands/team_test.py 100% <100%> (ø) ⬆️
command/commands/team.py 93.33% <72.72%> (-3.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362d704...f74bb7a. Read the comment docs.

docs/TeamCommands.md Outdated Show resolved Hide resolved
docs/TeamCommands.md Outdated Show resolved Hide resolved
tests/command/commands/team_test.py Show resolved Hide resolved
joy8zhang
joy8zhang previously approved these changes Nov 17, 2018
@rwblickhan rwblickhan merged commit d456b35 into master Nov 24, 2018
@rwblickhan rwblickhan deleted the team-command branch November 24, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement team command parsing Stub out team command Create initial team command documentation
4 participants