Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,17 @@

package com.uber.jenkins.phabricator.coverage;

import hudson.FilePath;
import hudson.model.Run;
import hudson.plugins.cobertura.CoberturaBuildAction;
import hudson.plugins.cobertura.CoberturaCoverageParser;
import hudson.plugins.cobertura.CoberturaPublisher;

import hudson.plugins.cobertura.Ratio;
import hudson.plugins.cobertura.targets.CoverageMetric;
import hudson.plugins.cobertura.targets.CoverageResult;
import org.xml.sax.SAXException;

import javax.xml.parsers.ParserConfigurationException;
import java.io.File;
import java.io.IOException;
import java.util.Arrays;
Expand All @@ -34,15 +39,6 @@
import java.util.logging.Level;
import java.util.logging.Logger;

import javax.xml.parsers.ParserConfigurationException;

import hudson.FilePath;
import hudson.model.AbstractBuild;
import hudson.model.Run;
import hudson.plugins.cobertura.Ratio;
import hudson.plugins.cobertura.targets.CoverageMetric;
import hudson.plugins.cobertura.targets.CoverageResult;

/**
* Provide Cobertura coverage data
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ protected void execute() {
sendMessage(null, null, null);
}
} catch (ConduitAPIException e) {
e.printStackTrace();
printStackTrace(e);
failTask();
} catch (IOException e) {
e.printStackTrace();
printStackTrace(e);
failTask();
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ protected void execute() {
this.result = Result.SUCCESS;
}
} catch (ConduitAPIException e) {
e.printStackTrace();
printStackTrace(e);
this.result = Result.FAILURE;
} catch (IOException e) {
e.printStackTrace();
printStackTrace(e);
this.result = Result.FAILURE;
}
}
Expand Down
8 changes: 8 additions & 0 deletions src/main/java/com/uber/jenkins/phabricator/tasks/Task.java
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,14 @@ protected void info(String message) {
logger.info(getTag(), message);
}

/**
* Prints stack trace
* @param e the exception to log
*/
protected void printStackTrace(Exception e) {
e.printStackTrace(logger.getStream());
}

/**
* Gets the task's tag.
* @return A string representation of this task's tag.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,14 @@ public boolean recordCoverage(String sha, CodeCoverageMetrics codeCoverageMetric
}
return true;
} catch (URISyntaxException e) {
e.printStackTrace();
e.printStackTrace(logger.getStream());
} catch (HttpResponseException e) {
// e.g. 404, pass
logger.info(TAG, "HTTP Response error recording metrics: " + e);
} catch (ClientProtocolException e) {
e.printStackTrace();
e.printStackTrace(logger.getStream());
} catch (IOException e) {
e.printStackTrace();
e.printStackTrace(logger.getStream());
}
}

Expand Down