Remove global stats variables for uhttp #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peter-edge, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yutongp, @anuptalwalkar and @madhuravi to be potential reviewers. |
ghost
reviewed
Feb 23, 2017
| func SetupHTTPMetrics(scope tally.Scope) { | ||
| httpScope := scope.Tagged(HTTPTags) | ||
| HTTPPanicCounter = httpScope.Counter("panic") | ||
| // Client is a client for stats. |
There was a problem hiding this comment.
Nit: I think metrics were moved to internal package, because of the globals, now they can become private structs in the uhttp package.
There was a problem hiding this comment.
Ugh haha ok, I'll do that
yutongp
reviewed
Feb 23, 2017
modules/uhttp/stats.go
Outdated
| @@ -33,31 +33,46 @@ const ( | |||
| TagMiddleware = "middleware" | |||
There was a problem hiding this comment.
Shall these tag names be private?
yutongp
reviewed
Feb 23, 2017
modules/uhttp/stats.go
Outdated
| @@ -18,7 +18,7 @@ | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
|
|
|||
| package stats | |||
| package uhttp | |||
There was a problem hiding this comment.
since we are moving stats back to uhttp, how about client? ;P
There was a problem hiding this comment.
Another PR I think :)
HelloGrayson
approved these changes
Feb 23, 2017
ghost
approved these changes
Feb 23, 2017
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.