Add heroku button #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,8 @@ | |||
| from __future__ import absolute_import | |||
| from flask import Flask, render_template, request, redirect, session | |||
| from rauth import OAuth2Service | |||
| from urlparse import urlparse | |||
| from flask_sslify import SSLify | |||
There was a problem hiding this comment.
please alphabetize imports
|
@zheller Thanks for the feedback! Let me know if I missed anything |
|
Cool, i think you may need to rebase and fix a merge conflict but its a +1 from me! |
…to add-heroku-button Conflicts: README.md
| import json | ||
| import os | ||
| import requests |
There was a problem hiding this comment.
oops forgot this, requests is not a std lib, you should also swap this section and above -- i think this was a problem in our code initially but would love if you did us a solid here.
|
@zheller like so? (sorry about this back-and-forth, I don't write Python in my dayjob) |
|
looks great! Thanks @friism |
|
We put up a blog post: https://blog.heroku.com/archives/2014/8/22/try_the_new_uber_api_on_heroku |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes PR #2