Skip to content

Path layer vertex shader improvements #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2020
Merged

Path layer vertex shader improvements #4111

merged 2 commits into from
Jan 15, 2020

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Improve readability of the shader
  • Correctness

SVG:

image

Before:

image

After:

image

@Pessimistress Pessimistress requested a review from tsherif January 7, 2020 22:56
@coveralls
Copy link

coveralls commented Jan 7, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 83.364% when pulling 012c324 on x/path-extrusion into 0ead9dc on master.

@Pessimistress Pessimistress mentioned this pull request Jan 9, 2020
Closed
@Pessimistress Pessimistress marked this pull request as ready for review January 13, 2020 21:52
@Pessimistress Pessimistress merged commit cb74907 into master Jan 15, 2020
@Pessimistress Pessimistress deleted the x/path-extrusion branch January 15, 2020 18:53
@Pessimistress Pessimistress mentioned this pull request Jan 15, 2020
Merged
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@Pessimistress @chrisgervang
Path layer vertex shader improvements (#4111)
7dabbe8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tsherif tsherif tsherif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pessimistress @coveralls @tsherif