Skip to content

Conversation

bandersen23
Copy link
Contributor

For #4290

Background

Expansion from #4400 - closed due to a better idea for the issue.
This will allow for an argument of offline and if so, will embed the necessary javascript into a script tag in the HTML file to allow for portability.

Change List

  • add offline argument to bindings
  • embed index.js from the CDN url into a static folder - will need to be manually updated each release.
  • write function to grab binding and add it into the template.

@ajduberstein - here's an update from your idea in #4400. I manually added the javascript from the CDN, but if there's a way to automate that on build, that would make it easier when there are updates. I don't have any ideas how to do that, but wanted to flag that for you!

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 80.683% when pulling bacb04b on bandersen23:js-embedding-i4290 into f65ac9c on uber:master.

@ajduberstein ajduberstein merged commit dd1c0b7 into visgl:master Mar 25, 2020
ajduberstein added a commit that referenced this pull request Mar 25, 2020
@ajduberstein
Copy link
Collaborator

Thank you for your patience here @bandersen23. Verified it locally on my machine without internet access–everything works.

if there's a way to automate that on build

This should be fine for now–I'll get it documented and released in a beta.

Pessimistress pushed a commit that referenced this pull request Mar 26, 2020
Thank you for your patience here @bandersen23. Verified it locally on my machine without internet access–everything works.

> if there's a way to automate that on build

This should be fine for now–I'll get it documented and released in a beta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants