Skip to content

pydeck: Support Tile3DLayer #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

pydeck: Support Tile3DLayer #4450

wants to merge 13 commits into from

Conversation

ajduberstein
Copy link
Collaborator

For #4103

Background

Change List

@coveralls
Copy link

coveralls commented Apr 4, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.006%) to 80.186% when pulling 37de80b on ajd/support-tile3d-layer into 33f8d2d on master.

@ajduberstein
Copy link
Collaborator Author

image

@ajduberstein ajduberstein force-pushed the ajd/support-tile3d-layer branch from d0ddff6 to 37de80b Compare April 7, 2020 07:56
ibgreen
ibgreen approved these changes Apr 8, 2020
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajduberstein ajduberstein marked this pull request as draft April 9, 2020 22:28
@ajduberstein
Copy link
Collaborator Author

Delaying this until we can make the loaders webpack externals. Otherwise the JS bundle in this change is quite large.

Pessimistress
Pessimistress reviewed Apr 9, 2020
View reviewed changes
modules/jupyter-widget/src/create-deck.js Outdated
import {Tiles3DLoader, CesiumIonLoader} from '@loaders.gl/3d-tiles';

// Note: deck already registers JSONLoader...
registerLoaders([CSVLoader, DracoWorkerLoader]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibgreen I thought we no longer have to register the DracoLoader for 3d-tiles to work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that was the plan but sadly I didn't get that done in time for 2.1.

@ajduberstein ajduberstein force-pushed the ajd/support-tile3d-layer branch from 37de80b to b15df42 Compare April 29, 2020 04:06
@coveralls
Copy link

coveralls commented Apr 29, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 80.152% when pulling 81f9994 on ajd/support-tile3d-layer into 554dec0 on master.

@ajduberstein ajduberstein force-pushed the ajd/support-tile3d-layer branch from b15df42 to 5503597 Compare April 29, 2020 04:43
@ajduberstein
Copy link
Collaborator Author

Delaying this until we can make the loaders webpack externals. Otherwise the JS bundle in this change is quite large.

The file at modules/jupyter-widget/dist/bundle.js appears to be 8.2 MB on both master and this branch. If no one minds, I'd like to merge this for now and figure out including loaders as webpack externals later.

@ajduberstein ajduberstein marked this pull request as ready for review April 29, 2020 05:53
@Pessimistress Pessimistress deleted the ajd/support-tile3d-layer branch November 25, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress left review comments

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajduberstein @coveralls @Pessimistress @ibgreen