fix(seer): improve invalidate and log #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
May 8, 2017
| }); | ||
| }; | ||
|
|
||
| const dataBlackList = ['zoomLevels']; |
There was a problem hiding this comment.
Comment please why is this black listed?
| overs.forEach((value, valuePath) => { | ||
| recursiveSet(props, valuePath, value); | ||
| if (valuePath[0] === 'data') { | ||
| props.data = [...props.data]; |
There was a problem hiding this comment.
This looks like we are copying a possibly one million item array? Can we slice it to length 20? Add a comment explaining this...
|
|
||
| const dataBlackList = ['zoomLevels']; | ||
|
|
||
| const transformData = data => { |
There was a problem hiding this comment.
Function header please, explain what kind of transformation we are doing
src/debug/seer-integration.js
Outdated
| }; | ||
|
|
||
| /** | ||
| * Log a layer properties to Seer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only invalidate the
dataif it has been set as an override.Also log a limit of 20 data items instead of the full list.