Skip to content

Conversation

Pessimistress
Copy link
Collaborator

project_to_clipspace bug introduced by #607

Copy link

@howtimeflies0 howtimeflies0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Why is this not caught by our updated rendering test?

@Pessimistress
Copy link
Collaborator Author

We don't have a test case that uses modelMatrix.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to block this fix. We should do a review before 4.1 is released.

@Pessimistress Pessimistress merged commit fc10a7c into master Jun 2, 2017
@Pessimistress Pessimistress deleted the modelmatrix branch June 2, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants