Seer performance badges for attribute updates and render #720
Conversation
ibgreen
commented
Jun 19, 2017
ibgreen
commented
| return formatted; | ||
| } | ||
|
|
||
| export function leftPad(string, length = 8) { |
| import './experimental'; | ||
| import './deprecated'; | ||
| import './debug/seer-integration'; | ||
| import './debug/seer-integration.spec'; |
There was a problem hiding this comment.
why changing this? we are already in the tests directory
There was a problem hiding this comment.
why changing this? we are already in the tests directory
Every other file in the test directory follows this .spec convention.
This convention is pretty common in the JS community. FWIW, it does have the advantage of easily distinguishing the two files e.g. in sublime tabs or when do command-open in the Chrome debugger.
src/lib/layer-manager.js
Outdated
| /** | ||
| * Set an override on the specified property and update the layers | ||
| */ | ||
| import {setPropOverrides, layerEditListener, initLayerInSeer, updateLayerInSeer} |
There was a problem hiding this comment.
what's this comment?
Yes looks strange, will remove.
Yes, we can play around with it, but I prefer to leave as-is for now. I want to see the count of how many updates have happened (often more important than the number). Also wanted the user to have a chance of understanding what it means. If we just have two numbers, it will also be confusing to the user. If I could provide a tooltip for these badges, with additional data might be the best option... |
2 participants
