Update example config files #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
approved these changes
Jun 21, 2017
| // It enables bundling against src in this repo rather than installed deck.gl module | ||
| module.exports = require('../webpack.config.local')(module.exports); | ||
| // This line enables bundling against src in this repo rather than installed deck.gl module | ||
| module.exports = env => env ? require('../webpack.config.local')(CONFIG)(env) : CONFIG; |
There was a problem hiding this comment.
npm run build won't work if you copy this example out of the deck.gl directory. Is this intentional?
There was a problem hiding this comment.
npm run build won't work if you copy this example out of the deck.gl directory. Is this intentional?
Hmm no, I wasn't aware that we had a build target in some of the examples. Should we delete it for consistency?
If we want to show an example with production builds, unit testing etc it would seem better to have one example (a special webpack production example) focused on that and keep all the other config files as minimal as possible.
There was a problem hiding this comment.
Deleting it sounds fine to me.
ibgreen
force-pushed
the
0621-example-configs
branch
from
4591716 to
ab3f1da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #723
Fixes #728