Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints from H3Index to H3IndexInput #171

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix type hints from H3Index to H3IndexInput #171

merged 1 commit into from
Jan 19, 2023

Conversation

4nthonylin
Copy link
Contributor

Noticed that cellToBoundary was type hinted to accept H3Index however it actually can accept H3InputIndex. Updated type hints for cellToBoundary and a few other functions I noticed that had the same problem.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3960695796

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.844%
Totals Coverage Status
Change from base Build 3941620029: 0.0%
Covered Lines: 529
Relevant Lines: 529
💛 - Coveralls

@nrabinowitz
Copy link
Collaborator

Thanks for contributing!

@nrabinowitz nrabinowitz merged commit 1b5a8cc into uber:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4nthonylin @coveralls @nrabinowitz