Skip to content

Fix inverted h3Distance test #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

Fix inverted h3Distance test #426

merged 1 commit into from
Jan 25, 2021

Conversation

isaacbrodsky
Copy link
Collaborator

@isaacbrodsky isaacbrodsky commented Jan 25, 2021 •
edited
Loading

Thanks @RichardVasquez for pointing this out. The test should assert commutativity.

Fixes #424

@isaacbrodsky
Fix inverted h3Distance test #424
3f27134 
Thanks @RichardVasquez for pointing this out. The test should assert commutativity.
@isaacbrodsky isaacbrodsky changed the title Fix inverted h3Distance test #424 Fix inverted h3Distance test Jan 25, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.25% when pulling 3f27134 on isaacbrodsky-patch-1 into b3a6a43 on master.

@isaacbrodsky isaacbrodsky merged commit 18bbb68 into master Jan 25, 2021
@isaacbrodsky isaacbrodsky deleted the isaacbrodsky-patch-1 branch January 25, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@dfellis dfellis Awaiting requested review from dfellis

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor error in testH3Distance.c?
3 participants
@isaacbrodsky @coveralls @nrabinowitz