Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Use logger correctly so errors aren't suppressed #260

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Use logger correctly so errors aren't suppressed #260

merged 3 commits into from
Sep 11, 2018

Conversation

maroux
Copy link
Contributor

@maroux maroux commented Jul 2, 2018

Fixes #259

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 90.631% when pulling b3332ce on maroux:fix_logger into 743d9a3 on uber:master.

@maroux maroux mentioned this pull request Jul 3, 2018
Open
@kageiit kageiit merged commit f1f7ae6 into uber-archive:master Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@kageiit kageiit kageiit approved these changes

@ChaitanyaPramod ChaitanyaPramod ChaitanyaPramod approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maroux @CLAassistant @coveralls @kageiit @ChaitanyaPramod