Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album support? #1

Open
oracle2b opened this issue Aug 9, 2012 · 9 comments
Open

Album support? #1

oracle2b opened this issue Aug 9, 2012 · 9 comments

Comments

@oracle2b
Copy link

oracle2b commented Aug 9, 2012

Can you support the viewing of Albums on imgur.com ?

@ubershmekel
Copy link
Owner

In theory, yes. I wonder how this should work though. Perhaps I should show the first image and up/down arrows should appear when an album is displayed? I don't think redditp should just "inline" albums as more slides, though that would be the easy solution, because then large albums would steal attention from other images which got more karma juice per image.

@ilydlci
Copy link

ilydlci commented Jan 29, 2017

I just got the following error when trying to display a Imgur album:

Uncaught TypeError: Cannot read property 'width' of null
at script.js:615
at Object.convert (EmbedIt.js:47)
at Object.embedit.embed (EmbedIt.js:126)
at createDiv (script.js:613)
at slideBackgroundPhoto (script.js:572)
at startAnimation (script.js:484)

Since the Imgur albums convertor calls the embedFunc callback with null.
I would call this an issue because although albums are not supported, the page should not break (instead it should show some error message and skip the unsupported link).

@Droyk
Copy link

Droyk commented Jun 10, 2017

So what happened @ubershmekel will album option ever come?

@ubershmekel
Copy link
Owner

I apologize, I realize albums are important and it's been a while. Especially for subreddits like /r/behindthegifs which are awesome. I would like to modify the way urls are converted to support many more kinds. Something like this: https://github.com/ubershmekel/urlpedia but I'm not yet quite sure about the details.

@Droyk
Copy link

Droyk commented Jun 12, 2017

I can understand that but my question is when you are going to implement it?
If you are just going to wait around then it will be too late this feature was requested on 2012 and now it is 2017.....
it's been 6 years and you are still thinking....

@ghost
Copy link

ghost commented Nov 28, 2017

I think the best way to go about it, if you choose to work on this, might be to (as you said) display the first image, but have a separate redditp-like subapp (under redditp.com/a/..., perhaps) that just does a specific imgur album, and it could be opened with a particular hotkey.

@ubershmekel
Copy link
Owner

I agree a hotkey or a button should just allow browsing through the album.

@ghost
Copy link

ghost commented Dec 6, 2017

@ubershmekel I might take a crack at adding imgur album support (just for browsing them at the moment) if you aren't already working on that.

@Droyk
Copy link

Droyk commented Feb 23, 2019

So after 7 years any updates?

@omegasome omegasome mentioned this issue Feb 8, 2024
felixs-alt added a commit to omegasome/redditp that referenced this issue May 31, 2024
Apply Gallery Color To Size, Not Index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants