feat(layerFlyTo): add flyTo position to layers #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwambach
suggested changes
Jul 29, 2020
src/scripts/types/layer-list.d.ts
Outdated
| interface LayerListItem { | ||
| id: string; | ||
| name: string; | ||
| description: string; | ||
| link: string; | ||
| subLayers: LayerListItem[]; | ||
| flyTo: GlobeView; |
There was a problem hiding this comment.
Unfortunately the layer list is not the right place for the flyto property because everything in here is beeing translated and you would have to sync the values over all 5 language files.
We keept all the layer related values in the /data/layers-config.file. From there they are built into each layers metadata.json file.
The problem ist that the file is only written when the layer is build so @pmast wrote a tool to update the layers metadata config on storage directly - see /scripts/update-metadata.sh
pwambach
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #417