feat(menuLinks): add about page and links to menu #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwambach
suggested changes
Jul 29, 2020
src/scripts/components/menu/menu.tsx
Outdated
| </li> | ||
| <li className={styles.menuListItem}> | ||
| <a | ||
| href={`https://storage.googleapis.com/esa-cfs-versions/electron/${version}/esa-climate-from-space-${version}-win.exe`} |
There was a problem hiding this comment.
Would be great if the urls come from the main config file similar to the other urls like baseUrlTiles etc. You can insert the version there already.
pwambach
reviewed
Jul 29, 2020
| </h1> | ||
| </div> | ||
| <div className={styles.description}> | ||
| <FormattedMessage id="projectDescription" /> |
There was a problem hiding this comment.
The about page should be markdown right?
There was a problem hiding this comment.
I thought we agreed on having it in the translations. 🤔
There was a problem hiding this comment.
Yes, but with markdown support :)
There was a problem hiding this comment.
Ah, I see! Thanks, will add it.
pwambach
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #423
closes #402