Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems in the search function #56

Closed
Gabriele69 opened this Issue Oct 16, 2018 · 36 comments

Comments

Projects
@Gabriele69
Copy link

Gabriele69 commented Oct 16, 2018

with the latest updates, a problem has started with the search function.
When I open the "contacts" window from the phone or directly from the contacts app, the cursor is automatically positioned in the search bar (well! First this did not happen and I had to make an extra step)
But by typing the letters on the keyboard, the search does not work. You can not do the research.
Sometimes it happens that the cursor, instead, does not position itself directly on the search bar (rarely, I did not notice which combination causes it), in this case, after positioning the cursor, the search works perfectly
I use BQ 4.5 DEV last update

@Gabriele69 Gabriele69 changed the title Search functoin problem Problems in the search function Oct 16, 2018

@resoli

This comment has been minimized.

Copy link

resoli commented Oct 16, 2018

I just installed and i'm under OTA5 on my krillin device. Same problems with the search. Manual browsing works. Searching contacts works from Messages app.

@pierrefrancois

This comment has been minimized.

Copy link

pierrefrancois commented Oct 24, 2018

Since update to OTA-5, same problem here on a BQ Aquaris 4.5 (krillin).

@hummlbach hummlbach added the bug label Oct 27, 2018

@hummlbach

This comment has been minimized.

Copy link
Collaborator

hummlbach commented Oct 27, 2018

I can confirm this. Something weird is going on there - sometimes the search works just fine and sometimes it silently does not filter the contacts. (For me the keyboard does never show up automatically after touching the magnifier.)

@yaroth

This comment has been minimized.

Copy link

yaroth commented Nov 7, 2018

Same here: search does not work. Happens after the update to 16.04. Nexus 5.

@Danfro

This comment has been minimized.

Copy link
Contributor

Danfro commented Nov 9, 2018

I am having the same trouble with search on my BQ E5.
@hummlbach : Search does not bring up the keyboard as well. I did filed this as separate bug #918 because this thread did not exist at that moment.
I found that search only works for the first time - mostly, not always.
Once I delete a few numbers or try a second search almost every time it does not work.
And sometimes I do not get favourites shown. Reported as well by David Gámiz Jiménez on the Supergroup TG thread today.

Because this thread covers more issues I will close #918.

@Anne017

This comment has been minimized.

Copy link
Contributor

Anne017 commented Nov 11, 2018

Same issue for me after OTA 5, stable channel, on FP2.

@idekovets

This comment has been minimized.

Copy link

idekovets commented Nov 20, 2018

I can confirm this. Search (in Russian) not work.
OTA-5 on Nexus 5

@hummlbach

This comment has been minimized.

Copy link
Collaborator

hummlbach commented Nov 26, 2018

Updated my pro5 (without wipe) to 16.04 rc channel on 2018-11-25. I'm not able to reproduce it there. Maybe a race condition somewhere.

@nikhilbhalwankar

This comment has been minimized.

Copy link

nikhilbhalwankar commented Dec 4, 2018

Facing same problem for Contact Search function on BQ E5 HD. I am on 16.04 Stable.

@fourloop2002

This comment has been minimized.

Copy link

fourloop2002 commented Dec 6, 2018

Confirmed on N5 dev. Did not work on 737, updated to 740, open/closed Contacts app, still not working. Search using Messaging app works.

@Danfro

This comment has been minimized.

Copy link
Contributor

Danfro commented Dec 7, 2018

Just had to flash my phone (no wipe) for other reasons. ;-)
The issue still remains [BQ E5, 16.04 rc 2018-W48].

@hummlbach

This comment has been minimized.

Copy link
Collaborator

hummlbach commented Dec 8, 2018

@mardy it seems this happens since the qtpim update. It still works with makos rc image of 29th of august. But doesn't work anymore with makos rc image of 26th of september. I'm not able to reproduce it on turbo.

@Anne017

This comment has been minimized.

Copy link
Contributor

Anne017 commented Dec 9, 2018

This issue disappeared for me after the update to OTA 6 today, stable channel, on FP2.
Please try this to confirm if it fixes the problem.

@bastos77

This comment has been minimized.

Copy link

bastos77 commented Dec 15, 2018

Confirmed bug on FP2 rc Channelm 16.04 (2018-W50)

@nikhilbhalwankar

This comment has been minimized.

Copy link

nikhilbhalwankar commented Dec 19, 2018

Requesting devs to please fix this issue on priority. Its a core functionality every phone needs all time.

@bastos77

This comment has been minimized.

Copy link

bastos77 commented Dec 20, 2018

still buggy on 2018-W51

@energius

This comment has been minimized.

Copy link

energius commented Dec 25, 2018

The issue is still exist. Search in Contacts and in Phone app is do not work.
Device: Nexus 5
Build: Ubuntu 16.04 LTS -armhf (20181012)

Addition: In contact list exists Latin and Cyrillic names.

@Gabriele69

This comment has been minimized.

Copy link
Author

Gabriele69 commented Jan 17, 2019

Requesting devs to please fix this issue on priority. Its a core functionality every phone needs all time.

I confirm and agree. Also because the search by choosing the letters that appear scrolling through the list does not help at all. I should remember how I saved the contact because the letter refers to the first letter in the contact card.

@pierrefrancois

This comment has been minimized.

Copy link

pierrefrancois commented Jan 17, 2019

The problem here is that this bug has no assignee. If anybody knows how to fix it, he is welcome.

@kugiigi

This comment has been minimized.

Copy link

kugiigi commented Jan 23, 2019

So far I'm making progress with the issue.
The issue is in the ContactListModel object.
Sometimes the filter stops being assigned correctly.
Setting it to be always contactsFilter makes the search always work.

@bastos77

This comment has been minimized.

Copy link

bastos77 commented Jan 23, 2019

Sometimes the filter stops being assigned correctly.

I can confirm, that sometimes it works and sometimes not.

@Danfro

This comment has been minimized.

Copy link
Contributor

Danfro commented Jan 23, 2019

Yep, search works not always. I would say most of the time, but not always.
But the OSK is not raised by default it I tap on search icon. OSK comes up only if I tap into the search field again.

kugiigi added a commit to kugiigi/address-book-app that referenced this issue Jan 25, 2019

Fixed ubports#56
Removed old workaround in "onContactsChanged"
@nikhilbhalwankar

This comment has been minimized.

Copy link

nikhilbhalwankar commented Feb 11, 2019

If the issue is fixed, how to get the update on phone? Do I need to switch to RC channel?

@kugiigi

This comment has been minimized.

Copy link

kugiigi commented Feb 11, 2019

The PR for the fix is still open so it's not yet in any channel

UniversalSuperBox added a commit that referenced this issue Feb 18, 2019

Fixed #56
Removed old workaround in "onContactsChanged"
@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Feb 18, 2019

Closed by #74

@UniversalSuperBox UniversalSuperBox added this to To do in OTA-8 via automation Feb 18, 2019

@UniversalSuperBox UniversalSuperBox moved this from To do to QA in OTA-8 Feb 18, 2019

@Gabriele69

This comment has been minimized.

Copy link
Author

Gabriele69 commented Feb 20, 2019

Hi. I had update my phone this morning (20/02/2019 RC Channel 16.04 2019W08). The issue is fixed ! Thank You to all developer !!

@toehold

This comment has been minimized.

Copy link

toehold commented Feb 28, 2019

Hi, using N5 Ubuntu 16.04 (2019-W09) I added 6 Contacts: A B, C D, E F, G H, I J and X Y; when I enter in the search field T or Z all contacts are shown which is not the case with other letters except: A,B,C,D,E,F,G,H,I,J,X and Y.

@UniversalSuperBox

This comment has been minimized.

Copy link
Member

UniversalSuperBox commented Feb 28, 2019

@toehold, I was able to reproduce that problem. I think it is another, separate bug, though. Could you file a new report here on address-book-app?

@jezek

This comment has been minimized.

Copy link

jezek commented Feb 28, 2019

FP2 (2019-W09)

  • opening contacts search from launcher (open messaging-app and then tap search button). The search field is shown, but not focused and the OSK doesn't pop up. Need to tap the search field for osk.
  • opening contacts search from phone app. The search field is shown and focused, the OSK is shown.
  • opening contacsts search from messaging app (start new message, tap + to add recipient). Search is not shown. Need to tap the search button, then search field is shown and focused, OSK is sown
  • contacts search in telefram app (hamburger menu -> contacts). Just sows contacts. When tapping search, search is shown, not focused. After search field tap, OSK pops out. (here search result al always right, but can't search some string inside names)

The searching alone is not always right and consistent. Sometimes I get for the same search term only relevant results, sometimes all contacts. If the search string is only 1 letter long (eg "x"), all contacts are shown.

@kugiigi

This comment has been minimized.

Copy link

kugiigi commented Feb 28, 2019

I would suggest trying out your findings in the stable channel and compare. They might be a separate issue that should logged separately. I was also able to replicate the issue on my MX4 in OTA 7

@jezek

This comment has been minimized.

Copy link

jezek commented Feb 28, 2019

@kugiigi I was not sure, what was this bug about and if it is fixed (the first post was about cursor positioning, or search results fails?). So I posted my current findings as detailed as I thought was enough, so the person with more insights can deduce if it is fixed or not. ;)

@Danfro

This comment has been minimized.

Copy link
Contributor

Danfro commented Feb 28, 2019

I had filed @jezek s problem with the search not opening the OSK already as #918 but closed it because I thought it to be a duplicate.
Now it seems that this is not the case. Reopend as #79.

@ziggutas

This comment has been minimized.

Copy link

ziggutas commented Mar 1, 2019

Nexus 7 (flo), rc, 2019-W09. Search works but cursor and OSK not present when opening app until one tap in the search bar brings them up.

@ziggutas

This comment has been minimized.

Copy link

ziggutas commented Mar 1, 2019

Couldn't figure out how to cross reference to #79 , so will add a separate comment!

@erik-kueng

This comment has been minimized.

Copy link

erik-kueng commented Mar 2, 2019

FP2
2019-W09
search works in contacts and phone-app, but not in massage-app

@ziggutas

This comment has been minimized.

Copy link

ziggutas commented Mar 2, 2019

BQ E4.5 2019-W09
Open phone app and search contacts works as expected.

Open contacts and search will work but initially the cursor and osk are not present. Single tap in search box brings them up.

Restart device, open contacts for the first time and search works as expected. Open contacts second and subsequent times and again the cursor & osk not present until search box tapped.
Two more restarts produced the same results.

@UniversalSuperBox UniversalSuperBox moved this from QA to Done in OTA-8 Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.