Fix "Internet connection lost" errors #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows 10 includes working adb drivers for many devices. The drivers we recommend people install are often more broken than these included ones. Fixes #1708
Prior to this change, it was possible for errors initializing or waiting on plugins to go undetected. Errors in wait() would bubble up to the "no-network" error, which has been even more confusing for users. Related, but does not fix: #1847
If Heimdall is started on Windows without the Microsoft Visual C++ 2012 Redistributable package installed, it will exit with status 3221225781. Since we're treating errors in wait() as fatal as of 3fa043c (and reinforced that decision in 4f3899c), catch and notify the user of this situation. They can choose to ignore it if they aren't installing on a Samsung device. I had to make some changes to the promise chains in the plugin index and in core.js. The changes to the plugin index caused several unit tests which were relying on very exact return values to fail, so they had to be refactored. Some tests didn't accurately describe or test their stated goals, so I fixed them up. This improves logging quite a lot.
Using 'npm install' causes npm to install the newest possible dependencies based on package.json. 'npm ci' uses package-lock.json instead. This ensures that releases are reproducible and so are test failures.
UniversalSuperBox
force-pushed
the
fix-windows-macos
branch
from
c6663df
to
67301f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1913 +/- ##
==========================================
+ Coverage 71.95% 72.28% +0.33%
==========================================
Files 25 25
Lines 845 884 +39
==========================================
+ Hits 608 639 +31
- Misses 237 245 +8
Continue to review full report at Codecov.
|
|
I've had successful installations on the Nexus 5, OnePlus One, and Volla Phone on macOS, Windows, and Linux (but not the Volla Phone on macOS because fastboot is broken there). |
|
I've uploaded the artifacts from the GitHub Actions run to https://nc.ubports.com/index.php/s/g7sB3xdRfPRsA53 for further testing. |
This was referenced Apr 20, 2021
Open
mariogrip
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1847, see there for more discussion of the issue.
(Done) Currently a draft PR. I haven't tested this fully on a Windows or macOS machine.
(Done) Requires ubports/promise-android-tools#56
(Done) Requires https://gitlab.com/ubports/installer/android-tools-bin is released