Yaru~~Dialog~~TitleBar: add support for leading & trailing widgets #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally implemented with help of AppBar that already offers these building blocks.
A commonly used name for title bars. :)
jpnurmi
changed the title
Merged
Feichtmeier
pushed a commit
that referenced
this pull request
Feb 22, 2024
Remove the outline and make the background color slightly stronger.
Feichtmeier
added a commit
that referenced
this pull request
Feb 25, 2024
* feat: Ubuntu Butterfly variant (#220) Now that yaru_colors.dart has the Ubuntu Butterfly Pink, we can have the variant in yaru.dart * Example: improve variant selector and show all * Add source code </> icon (#82) * Add source code </> icon Fixes #78 * Better icon * Sharper go-* icons (#85) * Fix icons misalignement (#86) * Adjust checkradio icons to yaru_widgets (#87) Fixes #79 * Icon request: standard device icons (#88) * Release version 0.2.7 (#89) * Add arrow and flag icons. (#92) Fixes #90 * Require yaru_colors 0.1.1 (#227) Fixes #225 * Improve toggle buttons look (#226) Fixes #223 * Better linting (#93) * Text inputs: change cursor and icon color to onSurface (#229) * Text inputs: change cursor color to onSurface * Change inputs icon color to onSurface * Release 0.4.4 (#230) * Refine project organization (#94) * checkmark icon look is outdated (#95) Fixes #91 * Pimp up example app (#96) * Fix camera-web overlay path (#97) * Extract animationController from animated icons (#98) Fixes #83 * Simplify all icon names (#100) * Rename toggle-button folder into toogle - Checkbox-button -> checkbox - Radio-button -> radio - Switch-button -> switch * Rename arrow icons - Arrow-*-simple -> arrow - Arrow -> arrow-filled * Rename audio -> music_note * Rename addon -> puzzle_piece * Rename arrow -> arrow-outlined * Optimize bettery naming - Battery-10 -> battery-full - Divide by 10 battery level - Remove level prefix * Simplify weather icon names Add new showers icon * Symlink online-accounts to could * Rename edit-*icons * Add folder-new icon * Improve media and text icon names * Optimize object icon names * Optimize object icon names * Sync printer-network with folder-network * Radio -> radiobox * Optimize speaker icon names * Revert example.dart * Optimize fullscreen icon names * Better computer-legacy icon * Simplify all other icon names * Add screen icon * Improve a few last icon names * Remove new icons (for next PR) * Fix battery empty name * Build font * Update example * Fix reserved switch const name (#101) * Add missing freedesktop icons (#105) * Add Freedesktop compliant icon names enum (#106) * Add binding enum of freedesktop compliant icon names Fixes #104 * Add shortcut to all icons * YaruTheme widget: build empty during accent color initialiation (#232) * YaruTheme widget: build empty during accent color initialiation Fixes: #231 * Use mocked GSettings in all widget tests * YaruTheme widget: fix dispose() order (#233) * Add missing filled icons (#107) Fixes #102 * Release version 1.0.0 (#108) * Add Ubuntu CoF icon without baseplates (#111) Fixes #110 * Add various packaging variant icons (#112) * 500ms wait duration for tooltips (#236) * Add missing light dialog theme background color (#235) * Add missing light dialog background color Fixes: #222 * Create dialog theme with a function - attempt 2 * Release 0.4.5 (#237) * Disable theme variant detection in tests (#238) Building an empty SizedBox instead of the actual application is bad for testing. Check if `FLUTTER_TEST` environment variable is set. Fixes: canonical/ubuntu-desktop-installer#1278 * Release 0.4.6 (#239) * Release version 1.0.1 (#114) * Dark theme borders: reduce opacity (#240) * Release 0.4.7 (#241) * Adjust TextField content padding (#242) To match the height of buttons by default. Notice that this only works with the default font size. For example, there's a tiny difference between the two after turning on the large text accessibility setting. * Reduce AppBar height (#243) From 48 to 47 to match with YaruTitleBar & GtkHeaderBar. Fixes: #502 * Remove repaint boundary from example app (#116) * Remove elevation on hover from ElevatedButton (#228) Fixes #224 * pubspec.yaml: try adding entries for all supported platforms (#247) * pubspec.yaml: try adding an empty entries for remaining platforms Ref: #246 * What about top-level platforms-entries used for Dart packages? * CHANGELOG.md: fix formatting (#248) * Release v0.4.8 (#249) * Add RepaintBoundary around animated icons (#117) * Create placeholder icon (#119) Fixes #118 * Add placeholder icon (static icon font) (#120) * Move RepaintBoundary before ClipRect (#121) * Realign placeholder icon with viexBox (#123) * Add a few semantic icon names (#122) Fixes #109 * Release version 1.0.2 (#124) * Fix deprecated_member_use (Flutter 3.7.0) (#255) * Fix deprecated_member_use (Flutter 3.7.0) ``` $ dart fix --apply --code deprecated_member_use Computing fixes in yaru.dart... 34.5s Applying fixes... 0.0s example/lib/view/colors_view.dart deprecated_member_use • 2 fixes example/lib/view/fonts_view.dart deprecated_member_use • 13 fixes lib/src/text/text_theme.dart deprecated_member_use • 13 fixes lib/src/themes/common_themes.dart deprecated_member_use • 8 fixes lib/src/themes/extensions.dart deprecated_member_use • 3 fixes 39 fixes made in 5 files. ``` * Run flutter format * Fix M3 dialogs and popups (Flutter 3.7.0) (#256) Fixes #253 * example: add macos (#258) * CI: no need to run tests when publishing to GH pages (#257) It's already done by the flutter-ci/test job. * Fix white dividers (M3 / Flutter 3.7.0) (#259) * Fix white dividers (Flutter 3.7.0) * Opaque divider color constants * Button vs. text field borders (#250) * Button vs. text field borders Fixes #244 * Fix border width and remove transparency * Lighten up dark textfields, improve example * example: add disabled button * Button vs. text field borders Fixes #244 * Fix disabled border * Bump minimum Flutter version to 3.7.0 (#260) * Use GtkSettings from gtk.dart (#254) Close: #246 * M3 fixes (#261) * M3: adjust yaru switch style Fixes #197 * Fix FAB color dark, text button theme dark, tabbar dark * Fix indicator * improve tabbbartheme * Fix icon theme and dropdown menu * Move fab color to fab theme * fix icon buttons * add inputtheme to menu * Add tonal button theme * Correct method and remove tonal it's for us the same as filled * Add navigationbartheme * Add navi rail theme and divider theme * fix navi rail theme * Fix checkbox contrast * Fix switches * add badge theme * lighter check border * fix example (#262) * Rework all themes with from seed (#263) * Fix secondary containers and chips (#264) * Fix button view * Release 0.5.0 (#265) * Update readme and screenshots (#266) * Brighten up some accent colors in the dark theme (#268) * Brighten up some accent colors in the dark theme Fixes #267 * Fix Light theme: surface and background got incorrectly switched in 0.5.0 (#270) * Example fix inputs view not having a const constructor (#271) * Release 0.5.1 (#272) * Regenerate package metadata (#273) Fixes: #246 (hopefully) * Relax Flutter version constraint to allow beta (#274) The current version of the beta channel is 3.7.0-1.5.pre i.e. it's still a pre-release version of 3.7.0 even though it's good enough for yaru because it contains all the API we depend on. ``` The current Flutter SDK version is 3.7.0-1.5.pre. Because yaru requires Flutter SDK version >=3.7.0, version solving failed. ``` * Release 0.5.2 (#275) * Add application icon (#126) * Add new *-bag icons (#127) * Release version 1.0.3 (#128) * Add missing flavors & update example (#279) * pubspec: add issue tracker link (#277) * pubspec.yaml: restore platform map (#276) * pubspec.yaml: restore platform map Fixes: #246 (again) * Bump version & update changelog * Revert "Bump version & update changelog" This reverts commit d90cd73489ef7e6146f5a4d41d6e6615c9870624. * Improve FAB style (#280) * Release 0.5.3 * Example: update deps (#129) * FAB colors have too high contrast (#283) Fixes #281 * Add animated compass icon (#131) * Commit generated_plugins (#130) * Dark theme: lighten borders, darken input fills (#284) * Update input theme to darker jet from yaru colors (#285) * Revert "Update input theme to darker jet from yaru colors (#285)" (#286) This reverts commit 14c21f8. * Separate outline and divider colors (#287) - divider color can stay as it is - make outline color more pronounced * Use filled buttons with a grey fill and an outline (#288) * Use filled buttons with a grey fill and an outline * add disabled bg color * Release 0.5.4 (#289) * Tone down outline borders (#292) Fixes #291 * Release 0.5.5 (#293) * Canvas masking issue on web platform (#136) Fixes #132 * Remove useless ClipRect (#139) * Add repeat single icon (#142) Fixes #141 * TextTheme: add missing headlineLarge and labelMedium (#297) Fixes: #295 * Example: attempt to clarify the buttons (#296) * FilledButton proposal (#298) Remove the outline and make the background color slightly stronger. * Release v0.5.6 (#299) * Add new music icons (#143) * Release version 1.0.4 (#144) * Sync light and dark themes (#306) Same assignments in the same order for easier side-by-side comparison. * Gitignore generated_plugins (#146) * Gitignore generated_plugins * Remove outdated files * Pass brightness to _createAppBarTheme() (#307) * BottomNavigationBarTheme: use onSurface in dark theme (#308) To unify with the light theme. NOTE: It's not clean white but #fafafa aka "porcelain". * indicatorColor: use primary for both light and dark themes (#309) It's only used for M2 tabs in Flutter but make it consistent between the light and dark themes anyway so it'll be possible to share the theme creation without parameterizing indicatorColor. * Remove redundant brightness arguments (#311) The brightness of color schemes is explicitly specified so we can use it directly from there instead of passing both around. * Unify light & dark theme creation (#312) * Realign podcast waves (#147) * Menus: use surface variant in dark theme, surface in light theme (#313) Ref: #302 * Switch: use onPrimary for selected thumb to match primary track (#314) * Release 0.5.7 (#316) * Add scrollbar margin (#317) * Use an extension for less verbose dark and light color scheme checks (#318) * add high contrast borders (#319) - uses previously unused `outlineVariant` for black/white outlines in light/dark themes - adds `isHighContrast` extension that checks whether the primary color is black/white - uses `outlineVariant` for borders in high contrast themes * Release 0.5.8 (#321) * Change FAB Color and shape (#323) * Change FAB Color and shape Fixes #294 Fixes #282 * Example: fix onPressed * updated with new fonts (#324) Added new static fonts from the new variable version we got this year. That includes: Light Regular Medium Bold and their Italic variants. The new fonts should ideally not break anything but improve readability. The biggest change is the slightly thinner stroke which is an improvement over the old font which was heavier than usual. * Release 0.6.0 (#325) * fix high contrast divider color (#326) * export colorscheme extension for convenience (#327) allows us to use `isHighContrast` etc in places like yaru_widgets * Release 0.6.1 (#328) * Revert "updated with new fonts (#324)" (#330) This reverts commit 819a009. * Release 0.6.2 (#331) * New API for animated icons (#148) * icons: Introduce new animated icon api * icons: Migrate existing animated icons * Transfer colors (back) to yaru.dart (#333) * Transfer colors (back) to yaru.dart Fixes #332 * remove color pics and links and fix color hex * Use current jet * Update lib/src/colors.dart Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com> * Update lib/src/colors.dart Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com> * Update lib/src/colors.dart Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com> * Update lib/src/colors.dart Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com> --------- Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com> * Add a slider theme, more similar to yaru gnome (#335) * Add a slider theme, more similar to yaru gnome - white thumb - more visible track - increased elevation to get a border - reduced focus ring radius - increased focus ring opacity * -1 px overlayRadius * More opacity for dark * TabBarTheme: grey overlay color (#334) * Align some theme function names to _createXXX (#336) * Move createYaruXXX functions to bottom of the file (#337) * restore new fonts (#339) This reverts commit ba0fc1b. * Release 0.7.0 (#338) * Release 0.7.0 * Add a DrawerTheme and ListTileTheme (#340) * Add a DrawerTheme * only top/bottom right radius * BorderRadiusDirectional * Migrate to Flutter 3.10 & Dart 3.0 (#342) * Migrate to Flutter 3.10 & Dart 3.0 * Restore 16px horizontal padding for buttons * Merge commonButtonStyle with type-specific button styles * Swap button style merge the other way around Use the common properties as defaults and let the type-specific properties override to avoid surprises. * Import YaruColorExtension from yaru_colors.dart (#341) * ci: pin flutter version at 3.10.x (#344) * feat: Adapt SwitchTheme to yaru gnome (#345) - transparent border - darker grey for inactive switches, based on the colorScheme to stay themeable * Release 0.8.0 (#346) * feat: deprecate YaruThemeDataExtension in favor of YaruColorSchemeExtension (#349) * feat: add YaruColorSchemeExtension.link and .inverseLink (#348) * feat: controls_view ToggleButtons & DropdownButton interactive (#347) * feat: controls_view ToggleButtons & DropdownButton interactive * feat: theme-specific error colors (#350) * chore: release v0.8.1 (#351) * feat(colors)!: introduce theme-specific semantic colors (#352) * feat: auto-detect Cinnamon & Unity (#353) * feat: add YaruColorExtension.toHex() for passing colors to HTML (#354) * chore(changelog): fix formatting (#356) * ci: let release-please maintain the changelog (#355) * ci: let release-please maintain the changelog * ci: validate PRs titles * ci(release): temp override release-as 0.9.0 (#358) * feat: add static YaruVariant.accents (#359) `YaruVariant.accents` includes only the Ubuntu accent colors and excludes any variants for Ubuntu flavors that are included in `YaruVariants.values`. * ci: exempt github-actions[bot] from the CLA check (#360) * chore: release v0.9.0 (#357) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * revert: "ci(release): temp override release-as 0.9.0 (#358)" This reverts commit 56fbf32. * chore: dependabot (#362) * chore: dependabot (#149) * chore: release-please (#150) * chore: package example as a snap (#137) * ci: reuse pr title & release actions from ufc/actions (#364) * ci: reuse pr title & release actions from ufc/actions (#151) * ci: specify FLUTTER_VERSION environment variable (#366) * chore: release as 2.0.0 (#154) Release-As: 2.0.0 * Add animated heart icon (#155) * refactor!: cleanup animated icons API and comments (#156) * feat: add showers-night icons (#157) * refactor: use a late animation controller (#158) * revert: "ci: reuse pr title & release actions from ufc/actions (#364)" This reverts commit dca12c2 * revert: "ci: reuse pr title & release actions from ufc/actions (#151)" This reverts commit 37017c7 * chore(example): show all colorscheme colors (#368) * chore(example): show all colorscheme colors * display onColor on color if provided * order theme sections by topic * fix trailing comma * show hex * keep alpha letters * !refactor: leanups, refactors, and comment (#160) * chore: release v2.0.0 (#153) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: bump sdk version to <4.0 (#161) * feat: add animated star icon (#163) Fixes #138 * chore: release 2.1.0 Release-As: 2.1.0 * fix: run the animation again on data change (#166) * feat: add YaruAnimatedIcon initialProgress property (#167) * chore: release v2.1.0 (#164) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: automatize viewBox trick in build script (#168) Fixes #159 * feat: mark dark theme darker (#373) Fixes #234 * fix: remove spacing for font styles (#372) Fixes #367 * feat: refresh example app (#170) - Use handy_window; - Use YaruWindowTitleBar; - Fix search input focus issue; - Various refactoring. Fixes #140, #134 * fix: change publish action branch to main (#171) * fix: update handy_window and use it correctly (#374) * fix: update handy_window and use it correctly Fixes #371 * Create handy window and headerbar in c++ * remove hdy_init call * fix: remove wrong flutter dir cmake manipulation (#375) * chore: release v0.10.0 (#361) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: remove appbar height (#378) Because we have our own CSD desktop titlebar with https://github.com/ubuntu/yaru_widgets.dart/blob/main/lib/src/widgets/yaru_title_bar.dart it is no longer needed to reduce the material appbar height Fixes #376 * chore: example rewrite (#381) * chore: example rewrite Fixes #380 * fix: add slider with value * fix: typo in YaruCanvasExtension class name (#174) * fix: YaruAnimatedOkIcon diff paint glitch (#173) * feat: rework YaruAnimatedNoNetworkIcon (#172) - Use a more linear curve to avoid whip effect ; - Decrease animation duration ; - Cleanup code. * feat!: Better platform independent sizes (#383) * feat!: Better platform independent sizes Fixes #369 * fix: example containers overflow * Axe padding rather than tiny icons * Use even sizes and yaru_icons in the example * shrink navibar if not mobile * feat: snackbar theme (#385) Fixes #384 * fix: reduce dark snackbar border brightness (#386) * fix: reduce dark snackbar border brightness * fix: improve light themes contrast (#387) by using jet instead of inkstone * fix: set default size for snackbars (#389) Fixes #388 * feat!: use different shade of the same color for primary, secondary, tertiary (#390) - use different shade of the same color for primary, secondary and tertiary ; - add cap and capDown Color extension. Fixes #300 * chore: release v1.0.0 (#379) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: use icon_font_generator 4.0 to fix font problems (#175) * chore: release v2.2.0 (#169) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: broken publish CI (#176) * fix: ClipRRect borderRadius non-nullable (#178) * chore: release v2.2.1 (#177) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update to flutter 3.13 (#391) * fix: snackbar visibility (#393) * feat: make dividers 1px thick (#394) * chore: release v1.1.0 (#392) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * ci: remove CLA check (#365) Co-authored-by: Ken VanDine <ken.vandine@canonical.com> * feat: added no splash factory (#395) * feat: added no splash factory * Update lib/src/themes/common_themes.dart * fix fail --------- Co-authored-by: Stefano Liuzzo Scorpo <stefano.liuzzo@devmy.it> Co-authored-by: Frederik Feichtmeier <frederik.feichtmeier@gmail.com> * Update yaru package versions (#180) Fixes #179 * chore: fix github pages flutter version (#181) * Add thumb icons (#183) * Add "chore(deps)" prefix to dependabot commit message (#185) * chore: better dependabot.yaml commit message prefix (#186) * fix: enable icon tree-shaking (#187) Add missing @staticIconProvider annotation to enable icon tree-shaking. * chore: release v2.2.2 (#182) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(deps): bump flutter_lints from 2.0.3 to 3.0.1 (#188) Bumps [flutter_lints](https://github.com/flutter/packages/tree/main/packages) from 2.0.3 to 3.0.1. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/pigeon-v3.0.1/packages) --- updated-dependencies: - dependency-name: flutter_lints dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: fixed typos (#402) Co-authored-by: Stefano Liuzzo Scorpo <stefano.liuzzo@devmy.it> * fix: Improve android support (#404) Fixes #401 * chore: release v1.2.0 (#397) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: rework some icons (#190) * Update readme (#192) * fix: theming background color (#405) * fix: updating a color to match figma * fix: removing a deprecated parameter * fix: updating the background color on light theme * chore: release v1.2.1 (#407) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: release v2.3.0 (#189) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: add accessibility icons (#194) * chore: release v2.4.0 (#195) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat!: use shapeshifter for all animated icons - 3.0 (#196) * fix(SnackBarTheme): improve SnackBarTheme (#409) Fixes #408 * chore: release v1.2.2 (#410) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: prepare yaru_widgets for yaru mono repo * chore: prepare for migration into yaru_widgets.dart * chore: prepare yaru_icons.dart for migration into yaru_widgets.dart * chore: move all source code back to lib * chore: format * fix: remove .DS_Store * chore: update readme and icons screenshot * fix: icons * fix: format yaru icons * chore: add icons command to readme * chore: update goldens * chore: add ThemePage to the example * fix: code snippet button * chore: update readme * chore: update images * fix: add Ubuntu fonts * fix: use the ubuntu font * chore: remove "here" --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Yannick Mauray <yannick.mauray@gmail.com> Co-authored-by: Paul Kepinski <paul.kepinski@orange.fr> Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com> Co-authored-by: Dennis Loose <dennis.loose@canonical.com> Co-authored-by: Elio Qoshi <ping@elioqoshi.me> Co-authored-by: Davide Bianco <dn.bianco03@gmail.com> Co-authored-by: Pietro Tamburini <pietro.tamburini.3@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: J-P Nurmi <jpnurmi@gmail.com> Co-authored-by: J-P Nurmi <jpnurmi@ubuntu.com> Co-authored-by: Ken VanDine <ken.vandine@canonical.com> Co-authored-by: TheLiux <62995808+TheLiux@users.noreply.github.com> Co-authored-by: Stefano Liuzzo Scorpo <stefano.liuzzo@devmy.it> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Enzo Conty <contact@enzoconty.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Yaru
DialogTitleBar with help of AppBar which already offers these building blocks.Pull request checklist