Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang CI: improve linting output #18

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Golang CI: improve linting output #18

merged 3 commits into from
Jun 2, 2022

Conversation

paulineribeyre
Copy link
Collaborator

@paulineribeyre paulineribeyre commented Jun 2, 2022 •
edited
Loading

Golang CI workflow: add workaround to display the file and line in addition to the linting error so we know what to fix

See this thread for context

Before:
Screen Shot 2022-06-02 at 4 30 46 PM

After:
Screen Shot 2022-06-02 at 4 30 54 PM

Improvements

  • Golang CI: improve linting output

BinamB
BinamB approved these changes Jun 2, 2022
View reviewed changes
Copy link

@BinamB BinamB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paulineribeyre paulineribeyre merged commit e8e0b83 into master Jun 2, 2022
@paulineribeyre paulineribeyre deleted the paulineribeyre-patch-1 branch June 2, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinamB BinamB BinamB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @BinamB