Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXD-1430 fix(core-metadata) #331

Merged
merged 4 commits into from
Aug 7, 2018
Merged

PXD-1430 fix(core-metadata) #331

merged 4 commits into from
Aug 7, 2018

Conversation

paulineribeyre
Copy link
Contributor

Instead of a broken link, display an error on the landing page if there's no metadata

abgeorge7
abgeorge7 reviewed Aug 7, 2018
View reviewed changes
Copy link
Contributor

@abgeorge7 abgeorge7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can we add a test for this?

Also is there a way to display the error text instead of the full error HTML?

@paulineribeyre
Copy link
Contributor Author

Yes I'm working on a PR with a test
The error displayed is just text, something like "Error: object_id 1234 not found"

@abgeorge7
Copy link
Contributor

I saw this:
screen shot 2018-08-07 at 12 26 43 pm

@paulineribeyre paulineribeyre merged commit 0433b7e into master Aug 7, 2018
@paulineribeyre paulineribeyre deleted the fix/core-metadata branch August 7, 2018 18:54
@cstephanos cstephanos mentioned this pull request Nov 4, 2022
Open
@urvi-occ urvi-occ mentioned this pull request Nov 4, 2022
Open
@pmartinov pmartinov mentioned this pull request Nov 5, 2022
Open
@cstephanos cstephanos mentioned this pull request Nov 5, 2022
Open
@urvi-occ urvi-occ mentioned this pull request Dec 25, 2022
Open
This was referenced Dec 25, 2022
Closed
Closed
@cstephanos cstephanos mentioned this pull request Dec 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 25, 2022
Open
@cstephanos cstephanos mentioned this pull request Dec 26, 2022
Open
@Mikisha10 Mikisha10 mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abgeorge7 abgeorge7 abgeorge7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @abgeorge7