Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/profile fed auth #934

Merged
merged 34 commits into from
Oct 15, 2021
Merged

Feat/profile fed auth #934

merged 34 commits into from
Oct 15, 2021

Conversation

mcannalte
Copy link
Contributor

@mcannalte mcannalte commented Oct 13, 2021

Jira Tickets:

New Features

  • Add detailed external login options to profile page, remove them from workspaces page
  • When checking external login status, check only the status of logins whose hosts match at least one selected data GUID

Bug Fixes

  • Fix direct download error messages from incorrectly rendering as links

Improvements

  • Check for an existing download in progress when user loads discovery page

Deployment changes

  • set "showExternalLoginsOnProfile": true for showing external logins on the profile page

@mcannalte
Copy link
Contributor Author

Reproducing the direct download error (resolved by this pr):

  • on preprod.healdata.org
  • select CDC WONDER study
  • click download
  • download job returns an error, which portal attempts to render as a link and open in a new window as if it were a file:
    Screenshot from 2021-10-14 10-26-26

@mcannalte
Copy link
Contributor Author

This branch is deployed in QA HEAL. Some points on testing:

  • Login is currently mocked for a test email. First, login under this test email and go to profile, see the external login when signed in:
    image
  • Test the download / export UI flow by selecting any study with data availability.
    • Optionally, try refreshing the page while a download is happening, and test that it still shows "Download in progress" (this is a new improvemet)
  • Next, sign out, add dev_login: you@uhicago.edu to the cookies, and sign back in
  • Navigate to profile page, inspect the external login view for a user not signed in to JCOIN (assuming that you, like me, aren't authorized for JCOIN w/ qa-heal, otherwise maybe try a different email):
    image
  • Navigate back to discovery page, select a study from JCOIN, and try to
    • Download
    • Export to WS
  • In both cases, you should see this popup:
    image
  • clicking the profile page link button should take you to profile page

@mcannalte mcannalte marked this pull request as ready for review October 14, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants