except Exception

fence/models.py

@@ -753,7 +753,7 @@ def migrate(driver):
             _set_on_delete_cascades(driver, delete_user_session, md)
 
             delete_user_session.commit()
-        except:
+        except Exception:
             delete_user_session.rollback()
             raise
         finally:

fence/resources/admin/admin_users.py

@@ -60,7 +60,7 @@ def connect_user_to_project(current_session, usr, project=None):
                 )
                 msg = "Success: user access" " created for a bucket in the project {0}"
                 response.append(msg.format(proj.name))
-            except:
+            except Exception:
                 msg = "Error user access not" " created for project {0} and bucket {2}"
                 response.append(msg.format(proj.name, bucket["name"]))
     return response

fence/resources/audit/client.py

@@ -22,11 +22,11 @@ def __init__(self, service_url, logger):
             self._validate_config()
             try:
                 self._ping()
-            except Exception as e:
+            except Exception:
                 if self.push_type == "api":
                     # the audit-service must be available when fence
                     # is configured to make API calls to it
-                    raise e
+                    raise
                 else:
                     traceback.print_exc()
                     self.logger.warning(

fence/resources/audit/utils.py

@@ -64,7 +64,7 @@ def create_audit_log_for_request(response):
                 request_url=request_url,
                 **audit_data,
             )
-    except:
+    except Exception:
         # TODO monitor this somehow
         traceback.print_exc()
         logger.error(f"!!! Unable to create audit log! Returning response anyway...")

fence/resources/openid/ras_oauth2.py

@@ -50,7 +50,7 @@ def get_userinfo(self, token, userinfo_endpoint):
             msg = res.text
             try:
                 msg = res.json()
-            except:
+            except Exception:
                 pass
             self.logger.error(
                 "Unable to get visa: status_code: {}, message: {}".format(