(PXP-10172): Fix invalid sequence warning #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13314
💛 - Coveralls |
tests/dbgap_sync/test_user_sync.py
Outdated
| @@ -717,7 +717,7 @@ def mock_merge(dbgap_servers, sess): | |||
|
|
|||
| # this function will be called once for each sftp server | |||
| # the test config file has 3 dbgap sftp servers | |||
There was a problem hiding this comment.
guessing this changed to 2?
There was a problem hiding this comment.
why is this change in the tests needed? the code change shouldn't have any impact
There was a problem hiding this comment.
Lol i dont remember making this change. Changing this back because its obviously breaking the unit tests
| @@ -370,7 +369,7 @@ def _match_pattern(filepath, id_patterns, encrypted=True): | |||
| Returns: | |||
| bool: whether the pattern matches | |||
| """ | |||
| id_patterns.append("authentication_file_phs(\d{6}).(csv|txt)") | |||
| id_patterns.append("authentication_file_phs(\\\d{6}).(csv|txt)") | |||
There was a problem hiding this comment.
doesn't this mean that you expect an actual \ in the file name?
i fixed the same warning in other repos last week, you can use a raw string to address this warning: r"..."
There was a problem hiding this comment.
Yeah i thought that was the solution too but it doesn't work :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
DeprecationWarning: invalid escape sequence '\d'in usersync while trying to read whitelist filename patterns.