Downloads through GA4GH DRS are recorded in audit service #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-burt-uch
approved these changes
Oct 5, 2023
| @@ -39,6 +39,13 @@ def create_audit_log_for_request(response): | |||
| in `enable_audit_logging` decorator), record an audit log. The data we | |||
| need to record the logs are stored in `flask.g.audit_data` before reaching | |||
| this code. | |||
|
|
|||
| TODO The audit service has the ability to record presigned URL "upload" logs but we are not | |||
There was a problem hiding this comment.
Do we need a ticket for this TODO?
There was a problem hiding this comment.
We can create a ticket but tbh this is more of an explanation for future-me looking for upload audit logs 🙂
PlanXCyborg
added
test-apis-centralizedAuth
test-apis-dbgapTest
and removed
@requires-fence
labels
grugna
added a commit
to chicagopcdc/fence
that referenced
this pull request
Nov 1, 2023
Downloads through GA4GH DRS are recorded in audit service (uc-cdis#1117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements