Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-4581 Fix/don't escape whitespaces as + for AWS signed URL #725

Merged
merged 3 commits into from
Oct 24, 2019
Merged

PXP-4581 Fix/don't escape whitespaces as + for AWS signed URL #725

merged 3 commits into from
Oct 24, 2019

Conversation

mfshao
Copy link
Contributor

@mfshao mfshao commented Oct 23, 2019 •
edited
Loading

From https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html

Percent-encode all other characters with %XY, where X and Y are hexadecimal characters (0-9 and uppercase A-F). For example, the space character must be encoded as %20 (not using '+', as some encoding schemes do) and extended UTF-8 characters must be in the form %XY%ZA%BC.

see uc-cdis/cdis-python-utils#42

Bug Fixes

  • Whitespaces in AWS S3 signed URL will be escaped as %20 instead of +

Dependency updates

  • Bump cdispyutils to 1.0.3

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 7998

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.47%
Totals Coverage Status
Change from base Build 7995: 0.0%
Covered Lines: 5081
Relevant Lines: 7314
💛 - Coveralls

@mfshao mfshao changed the title s/version Fix/don't escape whitespaces as + for AWS signed URL Oct 24, 2019
@mfshao mfshao changed the title Fix/don't escape whitespaces as + for AWS signed URL PXP-4581 Fix/don't escape whitespaces as + for AWS signed URL Oct 24, 2019
@mfshao mfshao marked this pull request as ready for review October 24, 2019 16:53
@mfshao mfshao merged commit 81365bb into master Oct 24, 2019
@mfshao mfshao deleted the fix/no-plus branch October 24, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

@fantix fantix Awaiting requested review from fantix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfshao @coveralls @paulineribeyre