Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PXP-6469): Limit service account to six projects per account #813

Merged
merged 9 commits into from
Aug 7, 2020

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Aug 3, 2020

Trying to register too many projects to a single google service account at once returns a timeout error from Fence.

Bug Fixes

  • Limit service accounts to 6 projects and added a 400 status code if attempt to register more. PXP-5889

Improvements

  • Added unit tests to test 6 project limit in the POST and PATCH /google/service_accounts endpoints
  • Parameterized the limit of projects a service account can have as SERVICE_ACCOUNT_LIMIT in config-default.yaml.

@github-actions
Copy link

github-actions bot commented Aug 3, 2020

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Aug 3, 2020

Pull Request Test Coverage Report for Build 9543

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 69.209%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/google.py 7 8 87.5%
Totals Coverage Status
Change from base Build 9540: 0.02%
Covered Lines: 5345
Relevant Lines: 7723

💛 - Coveralls

tests/google/test_service_accounts.py Show resolved Hide resolved
tests/google/test_service_accounts.py Show resolved Hide resolved
tests/google/test_service_accounts.py Outdated Show resolved Hide resolved
fence/blueprints/google.py Outdated Show resolved Hide resolved
tests/google/test_service_accounts.py Outdated Show resolved Hide resolved
@BinamB BinamB merged commit 5bf54d4 into master Aug 7, 2020
@BinamB BinamB deleted the fix/service-account-limit branch June 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants