Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PXP-6507): Handle denied access from any IDP #819

Merged
merged 6 commits into from
Aug 14, 2020
Merged

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Aug 13, 2020

Description about what this pull request does.

Please make sure to follow the DEV guidelines before asking for review.

New Features

  • Implemented a redirect to fence client specified redirect_uri when you deny consent from any idp.

@github-actions
Copy link

github-actions bot commented Aug 13, 2020

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Aug 13, 2020

Pull Request Test Coverage Report for Build 9600

  • 2 of 9 (22.22%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 69.154%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/login/base.py 2 9 22.22%
Totals Coverage Status
Change from base Build 9582: -0.05%
Covered Lines: 5347
Relevant Lines: 7732

💛 - Coveralls

Copy link
Contributor

@itsJiaqi itsJiaqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
we'll want to test this flow for our other IDPs too but should be good.

fence/blueprints/login/base.py Outdated Show resolved Hide resolved
fence/blueprints/login/base.py Outdated Show resolved Hide resolved
location = flask.session.get("redirect") or config["BASE_URL"]
redirect_url = urljoin(location, parsed_url.path)
return flask.redirect(location=redirect_url)
reqiest_url = flask.request.url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@BinamB BinamB merged commit b817ed6 into master Aug 14, 2020
@paulineribeyre paulineribeyre deleted the feat/handle-access branch August 14, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants