feat(cookies): always set httponly flag on cookies (also update deps) PXP-7593 #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avantol13
changed the title
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Avantol13
added
test-google-googleServiceAccountTest
test-google-GoogleServiceAccountRemoval
test-google-googleServiceAccountKeyTest
test-apis-dbgapTest
and removed
test-google-GoogleServiceAccountRemoval
test-google-googleServiceAccountKeyTest
test-google-googleServiceAccountTest
labels
paulineribeyre
approved these changes
Feb 8, 2021
tests/session/test_session.py
Outdated
| client.set_cookie("localhost", config["SESSION_COOKIE_NAME"], test_session_jwt) | ||
| client.set_cookie( | ||
| "localhost", config["SESSION_COOKIE_NAME"], test_session_jwt, httponly=True | ||
| ) | ||
| client.set_cookie( | ||
| "localhost", config["ACCESS_TOKEN_COOKIE_NAME"], test_access_jwt |
There was a problem hiding this comment.
what about this one?
There was a problem hiding this comment.
good catch! fixing
tests/session/test_session.py
Outdated
| client.set_cookie("localhost", config["SESSION_COOKIE_NAME"], test_session_jwt) | ||
| client.set_cookie( | ||
| "localhost", config["SESSION_COOKIE_NAME"], test_session_jwt, httponly=True | ||
| ) | ||
| client.set_cookie( | ||
| "localhost", config["ACCESS_TOKEN_COOKIE_NAME"], test_access_jwt |
There was a problem hiding this comment.
good catch! fixing
paulineribeyre
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes