Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PXP-7717): Implement ad-hoc usersync for single user after logging in through RAS #875

Merged
merged 8 commits into from
Feb 23, 2021
Merged

(PXP-7717): Implement ad-hoc usersync for single user after logging in through RAS #875

merged 8 commits into from
Feb 23, 2021

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Feb 19, 2021

Description about what this pull request does.

Please make sure to follow the DEV guidelines before asking for review.

New Features

  • Sync user's authorization information using visas as a source of information post login.

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Feb 19, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 10435

  • 60 of 83 (72.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 69.279%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/sync/sync_users.py 58 68 85.29%
fence/blueprints/login/ras.py 2 15 13.33%
Totals Coverage Status
Change from base Build 10426: -0.03%
Covered Lines: 5694
Relevant Lines: 8219
💛 - Coveralls

paulineribeyre
paulineribeyre reviewed Feb 22, 2021
View reviewed changes
fence/blueprints/login/ras.py Show resolved Hide resolved
fence/blueprints/login/ras.py Show resolved Hide resolved
fence/blueprints/login/ras.py Outdated Show resolved Hide resolved
tests/dbgap_sync/test_user_sync.py Show resolved Hide resolved
tests/dbgap_sync/test_user_sync.py Outdated Show resolved Hide resolved
tests/dbgap_sync/test_user_sync.py Show resolved Hide resolved
paulineribeyre
paulineribeyre reviewed Feb 22, 2021
View reviewed changes
tests/dbgap_sync/test_user_sync.py Outdated Show resolved Hide resolved
tests/dbgap_sync/test_user_sync.py Outdated Show resolved Hide resolved
BinamB and others added 2 commits February 22, 2021 16:01
@BinamB @paulineribeyre
Update tests/dbgap_sync/test_user_sync.py
857d93b 
Co-authored-by: Pauline Ribeyre <ribeyre@uchicago.edu>
@BinamB @paulineribeyre
Update tests/dbgap_sync/test_user_sync.py
1b4379f 
Co-authored-by: Pauline Ribeyre <ribeyre@uchicago.edu>
@BinamB BinamB merged commit 3fef376 into master Feb 23, 2021
@BinamB BinamB deleted the feat/visa_sync_loging branch February 23, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
test-apis-dbgapTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BinamB @coveralls @paulineribeyre @themarcelor