Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-2240: Add monitoring SA email in error msg #939

Merged
merged 18 commits into from
Jul 1, 2021
Merged

PXP-2240: Add monitoring SA email in error msg #939

merged 18 commits into from
Jul 1, 2021

Conversation

MaribelleHGomez
Copy link
Contributor

@MaribelleHGomez MaribelleHGomez commented Jun 24, 2021 •
edited
Loading

Jira Ticket: PXP-2240

New Features

  • email of monitor service account added to error msg
  • moved get_monitoring_service_account_response func out of class to be used globally

Breaking Changes

Bug Fixes

Improvements

Change warn to warning in logger due to dep warning

Dependency updates

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Jun 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 11329

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 71.018%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/google.py 8 10 80.0%
Totals Coverage Status
Change from base Build 11327: -0.02%
Covered Lines: 6197
Relevant Lines: 8726
💛 - Coveralls

BinamB
BinamB reviewed Jun 29, 2021
View reviewed changes
fence/blueprints/google.py Outdated Show resolved Hide resolved
fence/blueprints/google.py Show resolved Hide resolved
BinamB
BinamB approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@BinamB BinamB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really trusting you here. lgtm! 🤣

@MaribelleHGomez MaribelleHGomez merged commit 79b9096 into master Jul 1, 2021
@MaribelleHGomez MaribelleHGomez deleted the fix/sa_email branch July 1, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinamB BinamB BinamB approved these changes

Assignees
No one assigned
Labels
test-apis-rasIntegrationTest test-google-googleServiceAccountTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaribelleHGomez @coveralls @BinamB @PlanXCyborg